From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Duyck <alexander.duyck@gmail.com>,
Christoph Hellwig <hch@lst.de>,
Guenter Roeck <linux@roeck-us.net>
Cc: "open list:INTEL IOMMU (VT-d)" <iommu@lists.linux-foundation.org>,
Robin Murphy <robin.murphy@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 5/5] dma-direct: always allow dma mask <= physiscal memory size
Date: Tue, 09 Oct 2018 16:01:18 +1100 [thread overview]
Message-ID: <8402ecc9c8ed9c69ad3e91eca4d07a5ab077b22d.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAKgT0Ucii29i7S8eCj20D=a+=DeyKxREG0U2DBNRp3jFpgLu_A@mail.gmail.com>
On Wed, 2018-10-03 at 16:10 -0700, Alexander Duyck wrote:
> > - * Because 32-bit DMA masks are so common we expect every architecture
> > - * to be able to satisfy them - either by not supporting more physical
> > - * memory, or by providing a ZONE_DMA32. If neither is the case, the
> > - * architecture needs to use an IOMMU instead of the direct mapping.
> > - */
> > - if (mask < phys_to_dma(dev, DMA_BIT_MASK(32)))
> > + u64 min_mask;
> > +
> > + if (IS_ENABLED(CONFIG_ZONE_DMA))
> > + min_mask = DMA_BIT_MASK(ARCH_ZONE_DMA_BITS);
> > + else
> > + min_mask = DMA_BIT_MASK(32);
> > +
> > + min_mask = min_t(u64, min_mask, (max_pfn - 1) << PAGE_SHIFT);
> > +
> > + if (mask >= phys_to_dma(dev, min_mask))
> > return 0;
> > -#endif
> > return 1;
> > }
>
> So I believe I have run into the same issue that Guenter reported. On
> an x86_64 system w/ Intel IOMMU. I wasn't able to complete boot and
> all probe attempts for various devices were failing with -EIO errors.
>
> I believe the last mask check should be "if (mask < phys_to_dma(dev,
> min_mask))" not a ">=" check.
Right, that test is backwards. I needed to change it here too (powermac
with the rest of the powerpc series).
Cheers,
Ben.
next prev parent reply other threads:[~2018-10-09 5:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 22:35 dma mask related fixups (including full bus_dma_mask support) v2 Christoph Hellwig
2018-09-27 22:35 ` [PATCH 1/5] dma-mapping: make the get_required_mask method available unconditionally Christoph Hellwig
2018-09-27 22:35 ` [PATCH 2/5] dma-direct: add an explicit dma_direct_get_required_mask Christoph Hellwig
2018-09-27 22:35 ` [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection Christoph Hellwig
2018-09-27 22:35 ` [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling Christoph Hellwig
2018-09-27 22:35 ` [PATCH 5/5] dma-direct: always allow dma mask <= physiscal memory size Christoph Hellwig
2018-10-03 23:10 ` Alexander Duyck
2018-10-09 5:01 ` Benjamin Herrenschmidt [this message]
2018-11-19 14:18 ` Ramon Fried
2018-11-19 15:50 ` Robin Murphy
2018-11-20 7:38 ` Ramon Fried
2018-10-01 14:32 ` dma mask related fixups (including full bus_dma_mask support) v2 Christoph Hellwig
2018-10-01 20:51 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 18:52 dma mask related fixups (including full bus_dma_mask support) Christoph Hellwig
2018-09-20 18:52 ` [PATCH 5/5] dma-direct: always allow dma mask <= physiscal memory size Christoph Hellwig
2018-09-27 1:50 ` Benjamin Herrenschmidt
2018-09-27 13:49 ` Christoph Hellwig
2018-09-27 15:07 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8402ecc9c8ed9c69ad3e91eca4d07a5ab077b22d.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alexander.duyck@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).