From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8E53C432C3 for ; Fri, 15 Nov 2019 11:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7CD32072D for ; Fri, 15 Nov 2019 11:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfKOLt2 (ORCPT ); Fri, 15 Nov 2019 06:49:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:57548 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726983AbfKOLt2 (ORCPT ); Fri, 15 Nov 2019 06:49:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AEDCEADCB; Fri, 15 Nov 2019 11:49:25 +0000 (UTC) Subject: Re: Sense of soc bus? (was: [PATCH] base: soc: Export soc_device_to_device() helper) To: Rob Herring Cc: Greg Kroah-Hartman , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Geert Uytterhoeven , linux-realtek-soc@lists.infradead.org, Tony Lindgren , Linus Walleij , Bjorn Andersson , Thierry Reding , Fabio Estevam , Kevin Hilman , "Rafael J. Wysocki" , Michal Simek , Jonathan Hunter , NXP Linux Team , Sascha Hauer , "linux-tegra@vger.kernel.org" , linux-amlogic@lists.infradead.org, Lee Jones , linux-omap , Alexander Sverdlin , LAKML , "linux-kernel@vger.kernel.org" , Hartley Sweeten , Pengutronix Kernel Team , Shawn Guo , Architecture Mailman List , DTML References: <20191103013645.9856-3-afaerber@suse.de> <20191111045609.7026-1-afaerber@suse.de> <20191111052741.GB3176397@kroah.com> <586fa37c-6292-aca4-fa7c-73064858afaf@suse.de> <20191111064040.GA3502217@kroah.com> <20191112052347.GA1197504@kroah.com> <20191112072926.isjxfa4ci6akhx56@pengutronix.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <8411cceb-56f1-bcb3-96b6-5a2aaedd18cf@suse.de> Date: Fri, 15 Nov 2019 12:49:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.11.19 um 23:09 schrieb Rob Herring: > On Tue, Nov 12, 2019 at 4:47 AM Andreas Färber wrote: >> Finally, arch/arm seems unique in that it has the machine_desc mechanism >> that allows individual SoCs to force creating their soc_device early and >> using it as parent for further DT-created platform_devices. With arm64 >> we've lost that ability, and nios2 is not using it either. >> A bad side effect (with SUSE hat on) is that this parent design pattern >> does not allow to build such drivers as modules, which means that distro >> configs using arm's multi-platform, e.g., CONFIG_ARCH_MULTI_V7 will get >> unnecessary code creep as new platforms get added over time (beyond the >> basic clk, pinctrl, tty and maybe timer). >> Even if it were possible to call into a driver module that early, using >> it as parent would seem to imply that all the references by its children >> would not allow to unload the module, which I'd consider a flawed design >> for such an "optional" read-once driver. If we want the device hierarchy >> to have a soc root then most DT based platforms will have a /soc DT node >> anyway (although no device_type = "soc") that we probably could have a >> device registered for in common code rather than each SoC platform >> handling that differently? That might then make soc_register_device() >> not the creator of the device (if pre-existent) but the supplier of data >> to that core device, which should then allow to unload the data provider >> with just the sysfs data disappearing until re-inserted (speeding up the >> develop-and-test cycle on say not-so-resource-constrained platforms). > > I for one would like to for this to be consistent. Either we always > have an SoC device parent or never. I wouldn't decide based on having > a DT node or not either. Sure, if we can always be consistent, that might be best. Where I was coming from here is that, if we're not supposed to use soc_device_to_device(), then we have no way to associate an of_node with the soc_device from the outside (and nobody was doing it today, as per my analysis). We'd either need a new helper of_soc_device_register() with additional argument for the node, or it would need to be done entirely in the infrastructure as I suggested, be it by looking for one hardcoded /soc node or for nodes with device_type = "soc". Rob, in light of this discussion, should we start adding the latter property for new DTs such as my new Realtek SoCs, or was there a reason this has not been used consistently outside of powerpc and nios2? Intel/Altera appear to be the only two in arm64, with only three more in arm, none in mips. (BTW my assumption was that we don't follow the booting-without-of.txt documented schema of soc so that we can share .dtsi across differently named SoCs, is that correct?) > Generally, we should always have MMIO devices > under a bus node and perhaps more than one, but that doesn't always > happen. I think building the drivers as modules is a good reason to do > away with the parent device. > > It would also allow getting rid of remaining > of_platform_default_populate calls in arm platforms except for auxdata > cases. Pretty much that's the ones you list below in arch/arm/. The majority was indeed passing in NULL, so yeah, we might clean that up, if someone could come up with a plan of where/how to implement it. Cheers, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)