From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Ingo Molnar <mingo@elte.hu>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Manfred Spraul <manfred@colorfullife.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 0/6] rcu: introduce kfree_rcu V2
Date: Wed, 4 Mar 2009 14:00:54 +0200 [thread overview]
Message-ID: <84144f020903040400m5a77fc4p2b09796e1111c3b9@mail.gmail.com> (raw)
In-Reply-To: <20090304114504.GB4916@elte.hu>
On Wed, Mar 4, 2009 at 1:45 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> This is one of patches I test kfree_rcu().
>> And it could be an example conversions of this facility.
>>
>> ---
>> arch/ia64/sn/kernel/irq.c | 14 +-----------
>> block/genhd.c | 10 --------
>> ipc/sem.c | 10 +-------
>> kernel/audit_tree.c | 8 ------
>> kernel/cgroup.c | 9 -------
>> kernel/smp.c | 11 ---------
>> mm/vmalloc.c | 18 +--------------
>> net/can/af_can.c | 14 +-----------
>> net/core/gen_estimator.c | 9 -------
>> net/core/net_namespace.c | 10 --------
>> net/ipv4/fib_trie.c | 7 ------
>> net/ipv6/addrconf.c | 10 --------
>> net/netfilter/nf_conntrack_extend.c | 8 ------
>> net/netlabel/netlabel_unlabeled.c | 42 +-----------------------------------
>> security/device_cgroup.c | 10 --------
>> security/keys/keyring.c | 15 ------------
>> security/keys/user_defined.c | 18 +--------------
>> security/selinux/netif.c | 18 ---------------
>> security/selinux/netnode.c | 20 +----------------
>> security/selinux/netport.c | 20 +----------------
>> 20 files changed, 28 insertions(+), 253 deletions(-)
>
> Looks convincing to me but Nick does not like the extra SLAB
> field it uses :-/
FWIW, I'm fine with the patch series. One option for SLQB is to just
remove slab coloring as I've suggested in the past (the performance
benefit with current cpu caches is questionable).
Pekka
next prev parent reply other threads:[~2009-03-04 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 13:44 [PATCH -mm 0/6] rcu: introduce kfree_rcu V2 Lai Jiangshan
2009-03-03 14:09 ` Ingo Molnar
2009-03-04 9:22 ` Lai Jiangshan
2009-03-04 11:45 ` Ingo Molnar
2009-03-04 12:00 ` Pekka Enberg [this message]
2009-03-06 10:23 ` [PATCH] rcu: introduce kfree_rcu V3 Lai Jiangshan
2009-03-07 5:31 ` Paul E. McKenney
2009-03-03 15:11 ` [PATCH -mm 0/6] rcu: introduce kfree_rcu V2 Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020903040400m5a77fc4p2b09796e1111c3b9@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).