From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758024AbZCWRtS (ORCPT ); Mon, 23 Mar 2009 13:49:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752238AbZCWRtF (ORCPT ); Mon, 23 Mar 2009 13:49:05 -0400 Received: from rv-out-0506.google.com ([209.85.198.229]:38668 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753193AbZCWRtE (ORCPT ); Mon, 23 Mar 2009 13:49:04 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=ftom5nuRIji7b62n6UxO2Hoa+F0MbNjxbRQhKeoWkYljuei/yxSZxek7Mz5TcZN+rT 0y58QV7SMSvRDi3RXl3D9u7PfW3ZM0+s5axywzYeTEsaTpgqsCMo1I+gwrFrQk1o/h91 S5Bpih0fRxcaRKlf3zplyvP4Lt6pssydOj15U= MIME-Version: 1.0 In-Reply-To: <20090323165639.GA6841@elte.hu> References: <49AD3433.9000001@cn.fujitsu.com> <1237794502.6313.21.camel@penberg-laptop> <20090323155938.GA27151@elte.hu> <20090323165639.GA6841@elte.hu> Date: Mon, 23 Mar 2009 19:49:01 +0200 X-Google-Sender-Auth: 74850f28e706164e Message-ID: <84144f020903231049o11de5287w7bdb5c28e866dafb@mail.gmail.com> Subject: Re: [PATCH -mm 1/6] slab: introduce __kfree_rcu From: Pekka Enberg To: Ingo Molnar Cc: Christoph Lameter , Lai Jiangshan , Andrew Morton , Nick Piggin , "Paul E. McKenney" , Manfred Spraul , Peter Zijlstra , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 23, 2009 at 6:56 PM, Ingo Molnar wrote: > Anyway, these are nuances and if you go strictly by what's minimally > required by Documentation/CodingStyle you can stop a lot sooner than > having to bother about such fine details. The original version was > certainly acceptable - it's just that IMO Pekka was right that it > can be done better. Well, like I said, it was a minor nitpick, that's all. I would prefer it the way I and Ingo suggested but if you don't want to change it, that's fine as well.