From: Xiaoming Ni <nixiaoming@huawei.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: <keescook@chromium.org>, <ak@linux.intel.com>,
<alex.huangjianhui@huawei.com>, <linzichang@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysctl: Delete the code of sys_sysctl
Date: Wed, 10 Jun 2020 22:19:26 +0800 [thread overview]
Message-ID: <84286450-295b-b61b-f400-f08e7eafbe7c@huawei.com> (raw)
In-Reply-To: <87a71c59my.fsf@x220.int.ebiederm.org>
On 2020/6/10 3:20, Eric W. Biederman wrote:
> Xiaoming Ni <nixiaoming@huawei.com> writes:
>
>> Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"),
>> sys_sysctl has lost its actual role: any input can only return an error.
>
> The remaining code does have a role. It reports programs that attempt
> to use the removed sysctl.
>
> It would help if your change description had a reason why we don't want
> to warn people that a program has used a removed system call.
>
> Probably something like:
>
> We have been warning about people using the sysctl system call for years
> and believe there are no more users. Even if there are users of this
> interface if they have not complained or fixed their code by now they
> probably are not going to, so there is no point in warning them any
> longer.
>
> With a change like that made to the patch description.
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
Thanks for your guidance
I will add it in the v2 version
Thanks
Xiaoming Ni
prev parent reply other threads:[~2020-06-10 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 6:20 [PATCH] sysctl: Delete the code of sys_sysctl Xiaoming Ni
2020-06-09 15:40 ` Kees Cook
2020-06-10 14:17 ` Xiaoming Ni
2020-06-10 15:03 ` Kees Cook
2020-06-09 19:20 ` Eric W. Biederman
2020-06-10 14:19 ` Xiaoming Ni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84286450-295b-b61b-f400-f08e7eafbe7c@huawei.com \
--to=nixiaoming@huawei.com \
--cc=ak@linux.intel.com \
--cc=alex.huangjianhui@huawei.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linzichang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).