From: John Hubbard <jhubbard@nvidia.com>
To: Ira Weiny <ira.weiny@intel.com>, <john.hubbard@gmail.com>
Cc: <pavel@ucw.cz>, <SCheung@nvidia.com>, <akpm@linux-foundation.org>,
<aneesh.kumar@linux.vnet.ibm.com>, <benh@kernel.crashing.org>,
<bsingharora@gmail.com>, <dan.j.williams@intel.com>,
<dnellans@nvidia.com>, <ebaskakov@nvidia.com>,
<hannes@cmpxchg.org>, <jglisse@redhat.com>,
<kirill.shutemov@linux.intel.com>, <linux-kernel@vger.kernel.org>,
<liubo95@huawei.com>, <mhairgrove@nvidia.com>,
<mhocko@kernel.org>, <paulmck@linux.vnet.ibm.com>,
<ross.zwisler@linux.intel.com>, <sgutti@nvidia.com>,
<torvalds@linux-foundation.org>, <vdavydov.dev@gmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
Date: Thu, 18 Jul 2019 22:15:46 -0700 [thread overview]
Message-ID: <8428df79-94cc-cd17-1a48-c0e4b2202020@nvidia.com> (raw)
In-Reply-To: <20190719043439.GA26230@iweiny-DESK2.sc.intel.com>
On 7/18/19 9:34 PM, Ira Weiny wrote:
> On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubbard@gmail.com wrote:
>> From: John Hubbard <jhubbard@nvidia.com>
...
>> + Select HMM_MIRROR if you have hardware that meets the above
>> + description. An early, partial list of such hardware is:
>> + an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU.
>
> I don't think we want to put device information here. If we want that
> information in Kconfig best to put it in the devices themselves. Otherwise
> this list will get stale.
>
> Other than that, looks good.
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>
Hi Ira, thanks for the review, I'll remove that last sentence. I'll post a v2
with your reviewed by tag, in a new email thread. But first I'll wait to see
if there are other replies.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2019-07-19 5:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:41 HMM_MIRROR has less than useful help text Pavel Machek
2019-07-18 11:03 ` Balbir Singh
2019-07-18 14:25 ` Dan Williams
2019-07-18 16:36 ` Pavel Machek
2019-07-19 1:32 ` [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option john.hubbard
2019-07-19 4:34 ` Ira Weiny
2019-07-19 5:15 ` John Hubbard [this message]
2019-07-19 5:57 ` Christoph Hellwig
2019-07-19 10:52 ` Pavel Machek
2019-07-19 11:48 ` Jason Gunthorpe
2019-07-19 12:00 ` Christoph Hellwig
2019-07-19 12:04 ` Pavel Machek
2019-07-19 20:38 ` John Hubbard
2019-07-22 11:58 ` Jason Gunthorpe
2019-07-22 12:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8428df79-94cc-cd17-1a48-c0e4b2202020@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=SCheung@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dnellans@nvidia.com \
--cc=ebaskakov@nvidia.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=john.hubbard@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo95@huawei.com \
--cc=mhairgrove@nvidia.com \
--cc=mhocko@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pavel@ucw.cz \
--cc=ross.zwisler@linux.intel.com \
--cc=sgutti@nvidia.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).