From: Stefan Wahren <stefan.wahren@i2se.com>
To: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Cc: dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org,
kernel-list@raspberrypi.com, laurent.pinchart@ideasonboard.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, lukasz@jany.st,
mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org,
tomi.valkeinen@ideasonboard.com
Subject: Re: [RFC PATCH v3 05/11] ARM: dts: bcm2711: Add unicam CSI nodes
Date: Wed, 2 Feb 2022 19:24:06 +0100 [thread overview]
Message-ID: <84291425-6c7b-256a-24b6-c61197944211@i2se.com> (raw)
In-Reply-To: <20220202175639.149681-6-jeanmichel.hautbois@ideasonboard.com>
Hi Jean-Michel,
Am 02.02.22 um 18:56 schrieb Jean-Michel Hautbois:
> Add both MIPI CSI-2 nodes in the core bcm2711 tree. Use the 3-cells
> interrupt declaration, corresponding clocks and default as disabled.
>
> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
this patch needs an Ack from the BCM2835 maintainer(s), so please
include them. scripts/get_maintainers.pl is your friend.
> ---
> arch/arm/boot/dts/bcm2711.dtsi | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index dff18fc9a906..9ad50d4c0c16 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -3,6 +3,7 @@
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/soc/bcm2835-pm.h>
> +#include <dt-bindings/power/raspberrypi-power.h>
The file bcm2711.dtsi is reserved for the BCM2711 SoC and shouldn't used
for board specific stuff. So please ...
>
> / {
> compatible = "brcm,bcm2711";
> @@ -293,6 +294,30 @@ hvs: hvs@7e400000 {
> interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + csi0: csi@7e800000 {
> + compatible = "brcm,bcm2835-unicam";
> + reg = <0x7e800000 0x800>,
> + <0x7e802000 0x4>;
> + interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clocks BCM2835_CLOCK_CAM0>,
> + <&firmware_clocks 4>;
> + clock-names = "lp", "vpu";
> + power-domains = <&power RPI_POWER_DOMAIN_UNICAM0>;
move clocks property & power-domains property from this node and
> + status = "disabled";
> + };
> +
> + csi1: csi@7e801000 {
> + compatible = "brcm,bcm2835-unicam";
> + reg = <0x7e801000 0x800>,
> + <0x7e802004 0x4>;
> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clocks BCM2835_CLOCK_CAM1>,
> + <&firmware_clocks 4>;
> + clock-names = "lp", "vpu";
> + power-domains = <&power RPI_POWER_DOMAIN_UNICAM1>;
from this node to bcm2711-rpi.dtsi.
Best regards
> + status = "disabled";
> + };
> +
> pixelvalve3: pixelvalve@7ec12000 {
> compatible = "brcm,bcm2711-pixelvalve3";
> reg = <0x7ec12000 0x100>;
next prev parent reply other threads:[~2022-02-02 18:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 17:56 [RFC PATCH v3 00/11] Add support for BCM2835 camera interface (unicam) Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 01/11] media: v4l: Add V4L2-PIX-FMT-Y12P format Jean-Michel Hautbois
2022-02-02 21:06 ` Laurent Pinchart
2022-02-02 17:56 ` [RFC PATCH v3 02/11] media: v4l: Add V4L2-PIX-FMT-Y14P format Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 03/11] media: dt-bindings: media: Add bindings for bcm2835-unicam Jean-Michel Hautbois
2022-02-02 18:33 ` Stefan Wahren
2022-02-02 22:09 ` Jean-Michel Hautbois
2022-02-02 22:35 ` Laurent Pinchart
2022-02-03 11:36 ` Dave Stevenson
2022-02-02 17:56 ` [RFC PATCH v3 04/11] media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 05/11] ARM: dts: bcm2711: Add unicam CSI nodes Jean-Michel Hautbois
2022-02-02 18:24 ` Stefan Wahren [this message]
2022-02-02 17:56 ` [RFC PATCH v3 06/11] media: imx219: Rename mbus codes array Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 07/11] media: imx219: Switch from open to init_cfg Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 08/11] media: imx219: Introduce the set_routing operation Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 09/11] media: imx219: use a local v4l2_subdev to simplify reading Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 10/11] media: imx219: Add support for the V4L2 subdev active state Jean-Michel Hautbois
2022-02-02 17:56 ` [RFC PATCH v3 11/11] media: bcm283x: Include the imx219 node Jean-Michel Hautbois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84291425-6c7b-256a-24b6-c61197944211@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=kernel-list@raspberrypi.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lukasz@jany.st \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).