From: Guenter Roeck <linux@roeck-us.net>
To: Eddie James <eajames@linux.ibm.com>, Brandon Wyman <bjwyman@gmail.com>
Cc: linux-hwmon@vger.kernel.org, openbmc@lists.ozlabs.org,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/ibm-cffps) Do not swap max_power_out
Date: Mon, 30 Aug 2021 14:05:53 -0700 [thread overview]
Message-ID: <8433a40f-abbb-a0a9-9227-85363c2a9201@roeck-us.net> (raw)
In-Reply-To: <e329beeb2b8efa272d2660fcd253ad5c98a37c50.camel@linux.ibm.com>
On 8/30/21 1:11 PM, Eddie James wrote:
> On Mon, 2021-08-30 at 08:34 -0700, Guenter Roeck wrote:
>> On 8/30/21 6:50 AM, Eddie James wrote:
>>> On Sat, 2021-08-28 at 08:52 -0700, Guenter Roeck wrote:
>>>> On Fri, Aug 27, 2021 at 11:04:33PM +0000, Brandon Wyman wrote:
>>>>> The bytes for max_power_out from the ibm-cffps devices do not
>>>>> need
>>>>> to be
>>>>> swapped.
>>>>>
>>>>> Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
>>>>
>>>> Eddie, can you confirm this ?
>>>
>>> This can't be true for all the power supplies supported by this
>>> driver,
>>> no. I think we need to check the version first. Brandon, I tested
>>> this
>>> on witherspoon (which is psu version 1) and get 3148 watts. If it's
>>> not
>>> swapped, that would be 19468 watts...
>>>
>>
>> Hmm. Eddie, can you also have a look at commit 9fed8fa99334 ("hwmon:
>> (pmbus/ibm-cffps) Fix write bits for LED control") ?
>> We need to make sure that it doesn't mess up some versions of this
>> PS.
>
> That one looks correct to me. I believe older PSUs didn't enforce this
> so I didn't catch it, but I do see that the older specifications
> mention setting bit 6 to "allow write".
>
Great, thanks a lot for checking.
Guenter
next prev parent reply other threads:[~2021-08-30 21:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 23:04 [PATCH] hwmon: (pmbus/ibm-cffps) Do not swap max_power_out Brandon Wyman
2021-08-28 15:52 ` Guenter Roeck
2021-08-30 13:50 ` Eddie James
2021-08-30 15:34 ` Guenter Roeck
2021-08-30 20:11 ` Eddie James
2021-08-30 21:05 ` Guenter Roeck [this message]
2021-08-30 21:07 ` Brandon Wyman
2021-08-30 21:27 ` Guenter Roeck
2021-08-31 20:18 ` Brandon Wyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8433a40f-abbb-a0a9-9227-85363c2a9201@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bjwyman@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).