linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Juri Lelli <Juri.Lelli@arm.com>,
	Robin Randhawa <robin.randhawa@arm.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH 3/3] cpufreq: schedutil: irq-work is used only in slow path
Date: Fri, 11 Nov 2016 15:52:23 +0530	[thread overview]
Message-ID: <8435d76015786b26b343a5588e2758b4caf6760e.1478858983.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1478858983.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1478858983.git.viresh.kumar@linaro.org>

Execute the irq-work specific initialization/exit code only when fast
path isn't available.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/sched/cpufreq_schedutil.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 045ce0a4e6d1..219e717bcd15 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -371,9 +371,9 @@ static void sugov_policy_free(struct sugov_policy *sg_policy)
 	if (!sg_policy->policy->fast_switch_enabled) {
 		kthread_flush_worker(&sg_policy->worker);
 		kthread_stop(sg_policy->thread);
+		mutex_destroy(&sg_policy->work_lock);
 	}
 
-	mutex_destroy(&sg_policy->work_lock);
 	kfree(sg_policy);
 }
 
@@ -389,8 +389,6 @@ static struct sugov_policy *sugov_policy_alloc(struct cpufreq_policy *policy)
 		return NULL;
 
 	sg_policy->policy = policy;
-	init_irq_work(&sg_policy->irq_work, sugov_irq_work);
-	mutex_init(&sg_policy->work_lock);
 	raw_spin_lock_init(&sg_policy->update_lock);
 
 	/* kthread only required for slow path */
@@ -402,7 +400,6 @@ static struct sugov_policy *sugov_policy_alloc(struct cpufreq_policy *policy)
 	thread = kthread_create(kthread_worker_fn, &sg_policy->worker,
 			"sugov:%d", cpumask_first(policy->related_cpus));
 	if (IS_ERR(thread)) {
-		mutex_destroy(&sg_policy->work_lock);
 		kfree(sg_policy);
 		pr_err("failed to create sugov thread: %ld\n", PTR_ERR(thread));
 		return NULL;
@@ -416,6 +413,9 @@ static struct sugov_policy *sugov_policy_alloc(struct cpufreq_policy *policy)
 		return NULL;
 	}
 
+	init_irq_work(&sg_policy->irq_work, sugov_irq_work);
+	mutex_init(&sg_policy->work_lock);
+
 	kthread_bind_mask(thread, policy->related_cpus);
 	wake_up_process(thread);
 
@@ -578,8 +578,10 @@ static void sugov_stop(struct cpufreq_policy *policy)
 
 	synchronize_sched();
 
-	irq_work_sync(&sg_policy->irq_work);
-	kthread_cancel_work_sync(&sg_policy->work);
+	if (!policy->fast_switch_enabled) {
+		irq_work_sync(&sg_policy->irq_work);
+		kthread_cancel_work_sync(&sg_policy->work);
+	}
 }
 
 static void sugov_limits(struct cpufreq_policy *policy)
-- 
2.7.1.410.g6faf27b

      parent reply	other threads:[~2016-11-11 10:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 10:22 [PATCH 0/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-11 10:22 ` [PATCH 1/3] cpufreq: schedutil: enable fast switch earlier Viresh Kumar
2016-11-11 14:19   ` Peter Zijlstra
2016-11-11 21:52     ` Rafael J. Wysocki
2016-11-11 22:55       ` Peter Zijlstra
2016-11-11 21:58   ` Rafael J. Wysocki
2016-11-12  5:19     ` Viresh Kumar
2016-11-13 14:46       ` Rafael J. Wysocki
2016-11-14  4:06         ` Viresh Kumar
2016-11-14 11:30           ` Viresh Kumar
2016-11-11 10:22 ` [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar
2016-11-11 14:32   ` Tommaso Cucinotta
2016-11-11 14:39     ` Peter Zijlstra
2016-11-12  5:22       ` Viresh Kumar
2016-11-14  9:22         ` Peter Zijlstra
2016-11-14 10:22           ` Viresh Kumar
2016-11-12  5:21     ` Viresh Kumar
2016-11-11 22:16   ` Rafael J. Wysocki
2016-11-12  1:31     ` Saravana Kannan
2016-11-12  5:27       ` Viresh Kumar
2016-11-14  5:37         ` Viresh Kumar
2016-11-13 14:37       ` Rafael J. Wysocki
2016-11-13 19:47         ` Steve Muckle
2016-11-13 22:44           ` Rafael J. Wysocki
2016-11-14  6:36             ` Viresh Kumar
2016-11-12  5:24     ` Viresh Kumar
2016-11-13 19:31     ` Steve Muckle
2016-11-11 10:22 ` Viresh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8435d76015786b26b343a5588e2758b4caf6760e.1478858983.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=Juri.Lelli@arm.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=robin.randhawa@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).