From: Sebastien Boisvert <sboisvert@gydle.com>
To: Hans Holmberg <hans.ml.holmberg@owltronix.com>,
Matias Bjorling <mb@lightnvm.io>
Cc: Javier Gonzales <javier@cnexlabs.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans Holmberg <hans.holmberg@cnexlabs.com>
Subject: Re: [PATCH v2 7/7] lightnvm: pblk: remove dead code in pblk_recov_l2p
Date: Mon, 5 Nov 2018 10:31:27 -0500 [thread overview]
Message-ID: <844bd112-b9be-f63d-dfb1-42763fa83f0d@gydle.com> (raw)
In-Reply-To: <20181105122610.1555-8-hans.ml.holmberg@owltronix.com>
On 2018-11-05 7:26 a.m., Hans Holmberg wrote:
> From: Hans Holmberg <hans.holmberg@cnexlabs.com>
>
> Remove the call to pblk_line_replace_data as it returns
> directly as we have not set l_mg->data_next yet.
You have the word "as" twice. Replace the second with "because".
>
> Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
> ---
> drivers/lightnvm/pblk-recovery.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c
> index 0fbd30e0a587..416d9840544b 100644
> --- a/drivers/lightnvm/pblk-recovery.c
> +++ b/drivers/lightnvm/pblk-recovery.c
> @@ -805,7 +805,6 @@ struct pblk_line *pblk_recov_l2p(struct pblk *pblk)
> WARN_ON_ONCE(!test_and_clear_bit(meta_line,
> &l_mg->meta_bitmap));
> spin_unlock(&l_mg->free_lock);
> - pblk_line_replace_data(pblk);
> } else {
> spin_lock(&l_mg->free_lock);
> /* Allocate next line for preparation */
>
next prev parent reply other threads:[~2018-11-05 15:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 12:26 [PATCH v2 0/7] PBLK Bugfixes and cleanups Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 1/7] lightnvm: pblk: fix resubmission of overwritten write err lbas Hans Holmberg
2018-11-05 15:12 ` Sebastien Boisvert
2018-11-06 11:52 ` Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 2/7] lightnvm: pblk: account for write error sectors in emeta Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 3/7] lightnvm: pblk: stop writes gracefully when running out of lines Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 4/7] lightnvm: pblk: set conservative threshold for user writes Hans Holmberg
2018-11-05 21:15 ` kbuild test robot
2018-11-05 23:09 ` kbuild test robot
2018-11-05 12:26 ` [PATCH v2 5/7] lightnvm: pblk: remove unused macro Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 6/7] lightnvm: pblk: fix pblk_lines_init error handling path Hans Holmberg
2018-11-05 12:26 ` [PATCH v2 7/7] lightnvm: pblk: remove dead code in pblk_recov_l2p Hans Holmberg
2018-11-05 15:31 ` Sebastien Boisvert [this message]
2018-11-06 9:18 ` [PATCH v2 0/7] PBLK Bugfixes and cleanups Javier Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=844bd112-b9be-f63d-dfb1-42763fa83f0d@gydle.com \
--to=sboisvert@gydle.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=hans.ml.holmberg@owltronix.com \
--cc=javier@cnexlabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).