From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Guenter Roeck <linux@roeck-us.net>,
Peter Enderborg <peter.enderborg@sony.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Shakeel Butt <shakeelb@google.com>
Subject: Re: [RFC PATCH] watchdog: Adding softwatchdog
Date: Sun, 25 Apr 2021 00:23:32 +0900 [thread overview]
Message-ID: <844e3ecb-62c3-856a-7273-e22eee35e80f@i-love.sakura.ne.jp> (raw)
In-Reply-To: <d5db5606-f074-6d0e-2316-8ff41af25cfd@roeck-us.net>
On 2021/04/24 23:41, Guenter Roeck wrote:
> On 4/24/21 3:25 AM, Peter Enderborg wrote:
>> This is not a rebooting watchdog. It's function is to take other
>> actions than a hard reboot. On many complex system there is some
>> kind of manager that monitor and take action on slow systems.
>> Android has it's lowmemorykiller (lmkd), desktops has earlyoom.
>> This watchdog can be used to help monitor to preform some basic
>> action to keep the monitor running.
>>
>> It can also be used standalone. This add a policy that is
>> killing the process with highest oom_score_adj and using
>> oom functions to it quickly. I think it is a good usecase
>> for the patch. Memory siuations can be problematic for
>> software that monitor system, but other prolicys can
>> should also be possible. Like picking tasks from a memcg, or
>> specific UID's or what ever is low priority.
>> ---
>
> NACK. Besides this not following the new watchdog API, the task
> of a watchdog is to reset the system on failure. Its task is most
> definitely not to re-implement the oom killer in any way, shape,
> or form.
>
I don't think this proposal is a watchdog. I think this proposal is
a timer based process killer, based on an assumption that any slowdown
which prevents the monitor process from pinging for more than 0.5 seconds
(if HZ == 1000) is caused by memory pressure.
next prev parent reply other threads:[~2021-04-24 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-24 10:25 [RFC PATCH] watchdog: Adding softwatchdog Peter Enderborg
2021-04-24 10:25 ` Peter Enderborg
2021-04-24 12:21 ` Christophe Leroy
2021-04-24 13:04 ` Peter.Enderborg
2021-04-24 14:41 ` Guenter Roeck
2021-04-24 15:23 ` Tetsuo Handa [this message]
2021-04-24 16:19 ` peter enderborg
2021-04-25 1:08 ` Tetsuo Handa
2021-04-25 6:42 ` peter enderborg
2021-04-25 8:05 ` peter enderborg
2021-04-24 15:27 ` Peter.Enderborg
2021-04-24 17:07 ` Guenter Roeck
2021-04-24 17:20 ` Peter.Enderborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=844e3ecb-62c3-856a-7273-e22eee35e80f@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peter.enderborg@sony.com \
--cc=shakeelb@google.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).