From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD19C433E3 for ; Thu, 20 Aug 2020 06:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29EE5207DE for ; Thu, 20 Aug 2020 06:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Vd6WnZhH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725977AbgHTGTN (ORCPT ); Thu, 20 Aug 2020 02:19:13 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:16480 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgHTGTM (ORCPT ); Thu, 20 Aug 2020 02:19:12 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597904351; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=1Tw/sLiDck9pi6k/ICBYzHQlwO363+orOwakPWPDaPE=; b=Vd6WnZhH3N+rcBtLmHS1gzjNIxKK8jOnjOFVxEz4cDvHFL0Y5CXUHaUbKsMJc61t0qjevJWl m+Aiz1wHbEegP/Ff7ksv9vovHnuyGPhAGEkK0WqtNNcJxgO3HfoFl23qfjlWnJ0o0DUH9Sen p62TQm/QFmKy4q/jdV7d/hDs4mQ= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f3e15dece76f1f961940236 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 20 Aug 2020 06:19:10 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3F71FC433C6; Thu, 20 Aug 2020 06:19:10 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 34332C433CA; Thu, 20 Aug 2020 06:19:09 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 20 Aug 2020 11:49:09 +0530 From: Sai Prakash Ranjan To: Maulik Shah Cc: bjorn.andersson@linaro.org, agross@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, ulf.hansson@linaro.org, swboyd@chromium.org, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org, John Stultz , Stephen Rothwell Subject: Re: [PATCH 1/2] Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh" In-Reply-To: <1597831670-17401-2-git-send-email-mkshah@codeaurora.org> References: <1597831670-17401-1-git-send-email-mkshah@codeaurora.org> <1597831670-17401-2-git-send-email-mkshah@codeaurora.org> Message-ID: <8456a8006c0c165bb33dc34219eb7e5e@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-08-19 15:37, Maulik Shah wrote: > This change was done based on an test results of unmerged series of > adding RSC power domain and using .power_off callback of genpd to > invoke rpmh_flush(). > > Call trace: > dump_backtrace+0x0/0x174 > show_stack+0x20/0x2c > dump_stack+0xc8/0x124 > lockdep_rcu_suspicious+0xe4/0x104 > __tcs_buffer_write+0x230/0x2d0 > rpmh_rsc_write_ctrl_data+0x210/0x270 > rpmh_flush+0x84/0x24c > rpmh_domain_power_off+0x78/0x98 > _genpd_power_off+0x40/0xc0 > genpd_power_off+0x168/0x208 > > Later the final merged solution is to use CPU PM notification to invoke > rpmh_flush() and .power_off callback of genpd is not implemented in the > driver. > > Remove this change since RCU will not be idle during CPU PM > notifications > hence not required to use _rcuidle tracepoint. Using _rcuidle > tracepoint > prevented rpmh driver to be loadable module as these are not exported > symbols. > > This reverts commit efde2659b0fe835732047357b2902cca14f054d9. > > Cc: Sai Prakash Ranjan > Cc: John Stultz > Cc: Stephen Rothwell > Signed-off-by: Maulik Shah > --- Reviewed-by: Sai Prakash Ranjan Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation