From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F270C32751 for ; Wed, 31 Jul 2019 12:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BEDA206A3 for ; Wed, 31 Jul 2019 12:55:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388114AbfGaMzV (ORCPT ); Wed, 31 Jul 2019 08:55:21 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3270 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726300AbfGaMzV (ORCPT ); Wed, 31 Jul 2019 08:55:21 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id B4C32D6B18BC1BD2DCE3; Wed, 31 Jul 2019 20:55:18 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 20:55:11 +0800 Subject: Re: [PATCH 08/22] staging: erofs: kill CONFIG_EROFS_FS_IO_MAX_RETRIES To: Chao Yu CC: Greg Kroah-Hartman , , , LKML , , Miao Xie References: <20190729065159.62378-1-gaoxiang25@huawei.com> <20190729065159.62378-9-gaoxiang25@huawei.com> <1c979e3f-54ec-cce8-650c-39e060e72169@huawei.com> <2d7abbad-61d0-df2b-6a42-26f2606d775a@huawei.com> <985b3ca7-afee-006e-a367-98a865995246@huawei.com> From: Gao Xiang Message-ID: <845b43cb-3b9e-1b97-babe-a433078c4f9c@huawei.com> Date: Wed, 31 Jul 2019 20:55:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <985b3ca7-afee-006e-a367-98a865995246@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/31 20:10, Chao Yu wrote: > Hi Xiang, > > On 2019/7/31 15:11, Gao Xiang wrote: >> Hi Chao, >> >> On 2019/7/31 15:05, Chao Yu wrote: >>> On 2019/7/29 14:51, Gao Xiang wrote: >>>> CONFIG_EROFS_FS_IO_MAX_RETRIES seems a runtime setting >>>> and users have no idea about the change in behaviour. >>>> >>>> Let's remove the setting currently and fold it into code, >>>> turn it into a module parameter if it's really needed. >>>> >>>> Suggested-by: David Sterba >>>> Signed-off-by: Gao Xiang >>> >>> It's fine to me, but I'd like to suggest to add this as a sys entry which can be >>> more flexible for user to change. >> >> I think it can be added in the later version, the original view >> from David is that he had question how users using this option. >> >> Maybe we can use the default value and leave it to users who >> really need to modify this value (real requirement). > > I think we need to decide it in this version, otherwise it may face backward > compatibility issue if we change module argument to sys entry later. > > Maybe just leave it as an fixed macro is fine, since there is actually no > requirement on this. OK, will fix it --- leave the fixed macro. Thanks, Gao Xiang > > Thanks, > >> >> Thanks, >> Gao Xiang >> >>> >>> Thanks >>> >> . >>