From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E79EC433E4 for ; Thu, 23 Jul 2020 18:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDCD022CB3 for ; Thu, 23 Jul 2020 18:32:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gZHQd8X1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727881AbgGWSco (ORCPT ); Thu, 23 Jul 2020 14:32:44 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:51243 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727843AbgGWSco (ORCPT ); Thu, 23 Jul 2020 14:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595529162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sKozQ0KnMZ6/jFMcku3oZ38jLyvLbmaFhh4u3SNBWFc=; b=gZHQd8X1mQag8LfClpQ5wYmJ3wkB5LmbOpA4wcdC/tj+Qw2O9Wkpj1sAuUIXXuyGoAQIiF DPbyU9a2H6J3zoaMwpgSWbtGH4HUI6XruGUHEv02q2lObPiVSE4KGyLjY7SUdJYqcaults qBKc59ai/lUDhBtgyOEeaBIz2juw6+M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-a7YRzGORP6i5sZOBhCiJ6Q-1; Thu, 23 Jul 2020 14:32:40 -0400 X-MC-Unique: a7YRzGORP6i5sZOBhCiJ6Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8A501005510; Thu, 23 Jul 2020 18:32:38 +0000 (UTC) Received: from llong.remote.csb (ovpn-119-128.rdu2.redhat.com [10.10.119.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 209FA19D7E; Thu, 23 Jul 2020 18:32:37 +0000 (UTC) Subject: Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR To: Peter Zijlstra Cc: Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, Will Deacon , Boqun Feng , Ingo Molnar , Anton Blanchard , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm-ppc@vger.kernel.org, linux-arch@vger.kernel.org References: <20200706043540.1563616-1-npiggin@gmail.com> <20200706043540.1563616-6-npiggin@gmail.com> <874kqhvu1v.fsf@mpe.ellerman.id.au> <8265d782-4e50-a9b2-a908-0cb588ffa09c@redhat.com> <20200723140011.GR5523@worktop.programming.kicks-ass.net> From: Waiman Long Organization: Red Hat Message-ID: <845de183-56f5-2958-3159-faa131d46401@redhat.com> Date: Thu, 23 Jul 2020 14:32:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200723140011.GR5523@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/23/20 10:00 AM, Peter Zijlstra wrote: > On Thu, Jul 09, 2020 at 12:06:13PM -0400, Waiman Long wrote: >> We don't really need to do a pv_spinlocks_init() if pv_kick() isn't >> supported. > Waiman, if you cannot explain how not having kick is a sane thing, what > are you saying here? > The current PPC paravirt spinlock code doesn't do any cpu kick. It does an equivalence of pv_wait by yielding the cpu to the lock holder only. The pv_spinlocks_init() is for setting up the hash table for doing pv_kick. If we don't need to do pv_kick, we don't need the hash table. I am not saying that pv_kick is not needed for the PPC environment. I was just trying to adapt the pvqspinlock code to such an environment first. Further investigation on how to implement some kind of pv_kick will be something that we may want to do as a follow on. BTW, do you have any comment on my v2 lock holder cpu info qspinlock patch? I will have to update the patch to fix the reported 0-day test problem, but I want to collect other feedback before sending out v3. Cheers, Longman