From: <Eugen.Hristev@microchip.com>
To: <peda@axentia.se>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <wsa@the-dreams.de>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt
Date: Tue, 25 Jun 2019 09:14:13 +0000 [thread overview]
Message-ID: <84628b5e-bea7-7d91-f790-f3a2650040fa@microchip.com> (raw)
In-Reply-To: <4e81d3c9-25f3-ca6e-f2d5-17fad5905bb8@axentia.se>
On 25.06.2019 11:55, Peter Rosin wrote:
>
> On 2019-06-25 10:05, Eugen.Hristev@microchip.com wrote:
>> From: Eugen Hristev <eugen.hristev@microchip.com>
>>
>> Add binding specification for analogic filter inside the i2c controller
>
> s/analogic/the analog/
>
>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> index 8268595..20d334c 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-at91.txt
>> @@ -23,6 +23,9 @@ Optional properties:
>> - enable-dig-filt: Enable the built-in digital filter on the i2c lines,
>> specifically required depending on the hardware PCB/board and if the
>> version of the controller includes it.
>> +- enable-ana-filt: Enable the built-in analogic filter on the i2c lines,
>> + specifically required depending on the hardware PCB/board and if the
>> + version of the controller includes it.
>> - Child nodes conforming to i2c bus binding
>>
>> Examples :
>> @@ -60,6 +63,7 @@ i2c0: i2c@f8034600 {
>> atmel,fifo-size = <16>;
>> i2c-sda-hold-time-ns = <336>;
>> enable-dig-filt;
>> + enable-ana-filt;
>
> Perhaps
>
> microchip,digital-filter;
> microchip,analog-filter;
>
> ?
Hi Peter,
Thanks for reviewing. The name of the property does not matter much to
me, and we have properties prefixed with vendor, and some are not.
@Alexandre Belloni: which name you think it's best ?
Eugen
>
> Cheers,
> Peter
>
>>
>> wm8731: wm8731@1a {
>> compatible = "wm8731";
>>
>
next prev parent reply other threads:[~2019-06-25 9:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 8:04 [PATCH v2 0/9] i2c: at91: filters support for at91 SoCs Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 2/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 3/9] dt-bindings: i2c: at91: add binding for enable-dig-filtr Eugen.Hristev
2019-06-25 8:57 ` Peter Rosin
2019-06-25 8:04 ` [PATCH v2 4/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-06-25 8:04 ` [PATCH v2 5/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt Eugen.Hristev
2019-06-25 8:55 ` Peter Rosin
2019-06-25 9:14 ` Eugen.Hristev [this message]
2019-06-25 9:31 ` Alexandre Belloni
2019-06-25 9:55 ` I2C filtering (was Re: [PATCH v2 6/9] dt-bindings: i2c: at91: add binding for enable-ana-filt) Wolfram Sang
2019-06-27 13:22 ` Alexandre Belloni
2019-06-27 13:31 ` Eugen.Hristev
2019-06-27 13:34 ` Wolfram Sang
2019-06-27 13:39 ` Alexandre Belloni
2019-06-25 8:05 ` [PATCH v2 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 8/9] ARM: dts: at91: sama5d2_xplained: add analogic and digital filter for i2c Eugen.Hristev
2019-06-25 8:05 ` [PATCH v2 9/9] ARM: dts: at91: sama5d4_xplained: add analogic " Eugen.Hristev
2019-06-25 8:51 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84628b5e-bea7-7d91-f790-f3a2650040fa@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).