From: Dmitry Osipenko <digetx@gmail.com>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Mark Zhang <markz@nvidia.com>,
Venkat Reddy Talla <vreddytalla@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] regulator: max77620: Fix regulator info setting for max20024
Date: Mon, 22 Apr 2019 14:44:09 +0300 [thread overview]
Message-ID: <84db2f6a-f1b5-bd15-83ce-24ab321dff64@gmail.com> (raw)
In-Reply-To: <74253ed2-6b5a-0e59-25f0-05d7d8ce5431@gmail.com>
22.04.2019 14:39, Dmitry Osipenko пишет:
> 22.04.2019 8:35, Axel Lin пишет:
>> Current code always set pmic->rinfo[id] = &max77620_regs_info[id];
>> It should set to either max77620_regs_info or max20024_regs_info
>> depends on the chip_id.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> This was sent on https://lkml.org/lkml/2019/2/23/482
>>
>> drivers/regulator/max77620-regulator.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
>> index 1607ac673e44..0ad91a7f9cb9 100644
>> --- a/drivers/regulator/max77620-regulator.c
>> +++ b/drivers/regulator/max77620-regulator.c
>> @@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev)
>> continue;
>>
>> rdesc = &rinfo[id].desc;
>> - pmic->rinfo[id] = &max77620_regs_info[id];
>> + pmic->rinfo[id] = &rinfo[id];
>> pmic->enable_power_mode[id] = MAX77620_POWER_MODE_NORMAL;
>> pmic->reg_pdata[id].active_fps_src = -1;
>> pmic->reg_pdata[id].active_fps_pd_slot = -1;
>>
>
> That is a quite difficult bug to spot because the regulator parameters are mostly identical and the part that differs is usually unused in practice, good catch! Thank you very much!
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Tested-by: Dmitry Osipenko <digetx@gmail.com>
>
Axel, please also add a stable tag to the commit message to get the fix backported.
Cc: stable <stable@vger.kernel.org>
next prev parent reply other threads:[~2019-04-22 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 5:35 [PATCH RESEND] regulator: max77620: Fix regulator info setting for max20024 Axel Lin
2019-04-22 11:39 ` Dmitry Osipenko
2019-04-22 11:44 ` Dmitry Osipenko [this message]
2019-04-25 19:24 ` Applied "regulator: max77620: Fix regulator info setting for max20024" to the regulator tree Mark Brown
2019-04-25 19:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84db2f6a-f1b5-bd15-83ce-24ab321dff64@gmail.com \
--to=digetx@gmail.com \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).