From: Jerome Brunet <jbrunet@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org
Cc: linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/11] drm/meson: Add G12A Support
Date: Tue, 09 Apr 2019 10:42:37 +0200 [thread overview]
Message-ID: <84e8a61db1be6e83e7dcd9630fde17cfc59eb8a3.camel@baylibre.com> (raw)
In-Reply-To: <20190325141824.21259-1-narmstrong@baylibre.com>
On Mon, 2019-03-25 at 15:18 +0100, Neil Armstrong wrote:
> The Amlogic G12A SoC offers very close Video Display
> functionnalities with it's older GXBB, GXL & GXM predecessors.
>
> The main differences are :
> - G12A Support now 3 "real" OSD planes with a new Blender module
> - Instead of having a single Scaler for OSD1, G12A has two scaler
> that can be applied to 2 out of the 3 OSD planes or on the outputs
> of the blender module.
> - The HDMI PHY now support RX-SENSE, Dynamic HDR and it's registers are
> now memory mapped instead of using an internal bus.
> - The VPU now support a DSI interface to connect a display, using
> the Synopsys DSI controller and a custom PHY
>
> The complex Blender routing, HDMI RX-SENSE, Dynamic HDR and DSI support
> are not handled in this patchset.
>
> This patchset implements on-par support with the currently support
> GXBB, GXL and GXM SoCs. There is no support delta with this patchset.
>
> patch 10 & 11 implements the bindings found at [1].
>
> [1] https://lkml.kernel.org/r/20190313141030.5958-1-narmstrong@baylibre.com
>
> Neil Armstrong (11):
> drm/meson: Switch PLL to 5.94GHz base for 297Mhz pixel clock
> drm/meson: Add registers for G12A SoC
> drm/meson: Add G12A Support for VPP setup
> drm/meson: Add G12A Support for VIU setup
> drm/meson: Add G12A support for OSD1 Plane
> drm/meson: Add G12A Support for the Overlay video plane
> drm/meson: Add G12A support for plane handling in CRTC driver
> drm/meson: Add G12A support for CVBS Encoer
> drm/meson: Add G12A Video Clock setup
> drm/meson: Add G12A compatible
> drm/meson: Add G12A support for the DW-HDMI Glue
>
> drivers/gpu/drm/meson/meson_crtc.c | 269 +++++++++++++++++++-----
> drivers/gpu/drm/meson/meson_drv.c | 1 +
> drivers/gpu/drm/meson/meson_drv.h | 4 +
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 163 +++++++++++---
> drivers/gpu/drm/meson/meson_dw_hdmi.h | 32 ++-
> drivers/gpu/drm/meson/meson_overlay.c | 10 +-
> drivers/gpu/drm/meson/meson_plane.c | 15 +-
> drivers/gpu/drm/meson/meson_registers.h | 247 ++++++++++++++++++++++
> drivers/gpu/drm/meson/meson_vclk.c | 123 +++++++++--
> drivers/gpu/drm/meson/meson_venc.c | 11 +-
> drivers/gpu/drm/meson/meson_venc_cvbs.c | 25 ++-
> drivers/gpu/drm/meson/meson_viu.c | 72 ++++++-
> drivers/gpu/drm/meson/meson_vpp.c | 51 +++--
> 13 files changed, 880 insertions(+), 143 deletions(-)
>
on the u200 and sei510
Tested-by: Jerome Brunet <jbrunet@baylibre.com>
I can't pretend to have a deep understanding of this subsystem, but as far as
I can tell, there is nothing crazy in there. With the comments around the use
of constants and defines fixed, you can add
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
As a possible future enhancement, it would be nice if you could trim the use
of *_is_compatible() functions. I think it would make the code easier to
follow and review.
next prev parent reply other threads:[~2019-04-09 8:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:18 [PATCH 00/11] drm/meson: Add G12A Support Neil Armstrong
2019-03-25 14:18 ` [PATCH 01/11] drm/meson: Switch PLL to 5.94GHz base for 297Mhz pixel clock Neil Armstrong
2019-03-25 14:18 ` [PATCH 02/11] drm/meson: Add registers for G12A SoC Neil Armstrong
2019-03-25 14:18 ` [PATCH 03/11] drm/meson: Add G12A Support for VPP setup Neil Armstrong
2019-03-25 14:18 ` [PATCH 04/11] drm/meson: Add G12A Support for VIU setup Neil Armstrong
2019-04-09 8:42 ` Jerome Brunet
2019-04-09 9:19 ` Neil Armstrong
2019-03-25 14:18 ` [PATCH 05/11] drm/meson: Add G12A support for OSD1 Plane Neil Armstrong
2019-03-25 14:18 ` [PATCH 06/11] drm/meson: Add G12A Support for the Overlay video plane Neil Armstrong
2019-04-09 8:42 ` Jerome Brunet
2019-04-09 9:19 ` Neil Armstrong
2019-03-25 14:18 ` [PATCH 07/11] drm/meson: Add G12A support for plane handling in CRTC driver Neil Armstrong
2019-04-09 8:43 ` Jerome Brunet
2019-04-09 9:17 ` Neil Armstrong
2019-03-25 14:18 ` [PATCH 08/11] drm/meson: Add G12A support for CVBS Encoer Neil Armstrong
2019-04-09 8:43 ` Jerome Brunet
2019-04-09 8:44 ` Jerome Brunet
2019-04-09 9:18 ` Neil Armstrong
2019-04-09 9:18 ` Neil Armstrong
2019-03-25 14:18 ` [PATCH 09/11] drm/meson: Add G12A Video Clock setup Neil Armstrong
2019-04-09 8:46 ` Jerome Brunet
2019-04-09 9:19 ` Neil Armstrong
2019-03-25 14:18 ` [PATCH 10/11] drm/meson: Add G12A compatible Neil Armstrong
2019-03-25 14:18 ` [PATCH 11/11] drm/meson: Add G12A support for the DW-HDMI Glue Neil Armstrong
2019-04-09 8:42 ` Jerome Brunet [this message]
2019-04-09 8:51 ` [PATCH 00/11] drm/meson: Add G12A Support Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e8a61db1be6e83e7dcd9630fde17cfc59eb8a3.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).