From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933166AbcKNQl2 (ORCPT ); Mon, 14 Nov 2016 11:41:28 -0500 Received: from gloria.sntech.de ([95.129.55.99]:45841 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbcKNQlY (ORCPT ); Mon, 14 Nov 2016 11:41:24 -0500 From: Heiko Stuebner To: Elaine Zhang Cc: mturquette@baylibre.com, sboyd@codeaurora.org, xf@rock-chips.com, rocky.hao@rock-chips.com, huangtao@rock-chips.com, xxx@rock-chips.com, jay.xu@rock-chips.com, linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change Date: Mon, 14 Nov 2016 17:41:05 +0100 Message-ID: <8521074.U32oiGVMPt@phil> User-Agent: KMail/5.2.3 (Linux/4.7.0-1-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <1478596214-761-1-git-send-email-zhangqing@rock-chips.com> References: <1478596214-761-1-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 8. November 2016, 17:10:14 CET schrieb Elaine Zhang: > If validity is not checked prior to clock rate change, clk_set_rate( > cpu_clk, unsupported_rate) will return success, but the real clock rate > change operation is prohibited in post clock change event. Alough post > clock change event will report error due to unsupported clock rate is > set, but this error message is ignored by clock framework. > > Signed-off-by: Elaine Zhang > Signed-off-by: Rocky Hao after Elaine clarified that the line mentioning Rocky was actually a tested-by, applied to my clock branch Thanks Heiko