From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, w.egorov@phytec.de
Subject: Re: [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing
Date: Mon, 05 Mar 2018 18:04:48 +0100 [thread overview]
Message-ID: <8543411.nbQLj7Vctj@diego> (raw)
In-Reply-To: <cecf3c08-d43d-c340-c5ff-30e41e338469@phytec.de>
Hi Daniel,
Am Montag, 5. März 2018, 16:57:13 CET schrieb Daniel Schultz:
> On 03/05/2018 03:15 PM, Heiko Stuebner wrote:
> > Am Montag, 5. März 2018, 13:45:11 CET schrieb Daniel Schultz:
> >> The CLK_O_SEL default is synchronous to XI input clock, which is 25 MHz.
> >> Set CLK_O_SEL to channel A transmit clock so we have 125 MHz on CLK_OUT.
> >>
> >> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> >> ---
> >>
> >> The binding will be added with the next merge of net-next:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit
> >> /?id=9708fb630d19ee51ae3aeb3a533e3010da0e8570
> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Docum
> entation/devicetree/bindings/net/ti,dp83867.txt
>
> If I search in the master branch, I get the patch. Did I searched wrong?
no ... seems I was just blind :-)
Heiko
> > I did find the commit, but no related change of the dp83867 dt binding
> > document [0], including a review by dt-maintainers.
> >
> > While your property does not look overly complicated, the binding
> > should be updated nontheless.
> >
> >
> > Heiko
> >
> > [0]
> > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/log/Do
> > cumentation/devicetree/bindings/net/ti,dp83867.txt?id=9708fb630d19ee51ae3a
> > eb3a533e3010da0e8570>
> >> arch/arm/boot/dts/rk3288-phycore-som.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288-phycore-som.dtsi
> >> b/arch/arm/boot/dts/rk3288-phycore-som.dtsi index bdd80aa..e60535d
> >> 100644
> >> --- a/arch/arm/boot/dts/rk3288-phycore-som.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288-phycore-som.dtsi
> >> @@ -141,6 +141,7 @@
> >>
> >> ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> >> ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
> >> enet-phy-lane-no-swap;
> >>
> >> + ti,clk-output-sel = <DP83867_CLK_O_SEL_CHN_A_TCLK>;
> >>
> >> };
> >>
> >> };
> >>
> >> };
next prev parent reply other threads:[~2018-03-05 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 12:45 [PATCH] ARM: dts: rockchip: Add dp83867 CLK_OUT muxing Daniel Schultz
2018-03-05 14:15 ` Heiko Stuebner
2018-03-05 15:57 ` Daniel Schultz
2018-03-05 17:04 ` Heiko Stübner [this message]
2018-03-05 20:25 ` Heiko Stübner
2018-03-05 21:08 ` Heiko Stübner
2018-03-06 9:59 ` Daniel Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8543411.nbQLj7Vctj@diego \
--to=heiko@sntech.de \
--cc=d.schultz@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).