From: Banajit Goswami <bgoswami@codeaurora.org>
To: srinivas.kandagatla@linaro.org, lee.jones@linaro.org,
robh+dt@kernel.org, broonie@kernel.org
Cc: mark.rutland@arm.com, lgirdwood@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
vkoul@kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 11/14] ASoC: wcd9335: add mbhc support
Date: Wed, 26 Sep 2018 02:31:59 -0700 [thread overview]
Message-ID: <8582abce-b1c8-24fc-7db2-b7101a6e1362@codeaurora.org> (raw)
In-Reply-To: <20180917005727.32728-12-srinivas.kandagatla@linaro.org>
On 9/16/2018 5:57 PM, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/wcd9335.c | 268 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 266 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c
> index efbb698..6c95cff 100644
> --- a/sound/soc/codecs/wcd9335.c
> +++ b/sound/soc/codecs/wcd9335.c
> @@ -89,12 +90,18 @@
> #define CF_MIN_3DB_75HZ 0x1
> #define CF_MIN_3DB_150HZ 0x2
>
> +#define WCD9335_MBHC_MAX_BUTTONS (8)
Though MBHC HW supports button detection up to 8, we are only supporting
4 buttons in SW, right ?
> +
> #define WCD9335_SLIM_RX_CH(p) \
> {.port = p + WCD9335_RX_START, .shift = p,}
>
> #define WCD9335_SLIM_TX_CH(p) \
> {.port = p, .shift = p,}
> @@ -3988,6 +4003,131 @@ static int wcd9335_codec_enable_ear_pa(struct snd_soc_dapm_widget *w,
> return ret;
> }
>
> +static irqreturn_t wcd9335_mbhc_sw_irq(int irq, void *data)
Are we supporting only headset and headphone detection for now ?
Extension cable and electrical detection will be supported later ?
And how about cases for slow insertion scenarios ?
> +{
> + struct wcd9335_codec *wcd = data;
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-09-26 9:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 0:57 [PATCH v4 00/14] ASoC: Add support to WCD9335 Audio Codec srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 01/14] ASoC: dt-bindings: update wcd9335 bindings srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 02/14] mfd: wcd9335: add support to wcd9335 core srinivas.kandagatla
2018-10-24 7:07 ` Lee Jones
2018-10-24 10:50 ` Srinivas Kandagatla
2018-09-17 0:57 ` [PATCH v4 03/14] mfd: wcd9335: add wcd irq support srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 04/14] ASoC: wcd9335: add support to wcd9335 codec srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 05/14] ASoC: wcd9335: add CLASS-H Controller support srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 06/14] ASoC: wcd9335: add basic controls srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 07/14] ASoC: wcd9335: add playback dapm widgets srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 08/14] ASoC: wcd9335: add capture " srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 09/14] ASoC: wcd9335: add audio routings srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 10/14] ASoC: dt-bindings: Add WCD9335 MBHC specific properties srinivas.kandagatla
2018-09-26 9:27 ` Banajit Goswami
2018-09-17 0:57 ` [PATCH v4 11/14] ASoC: wcd9335: add mbhc support srinivas.kandagatla
2018-09-26 9:31 ` Banajit Goswami [this message]
2018-09-26 10:56 ` Srinivas Kandagatla
2018-09-17 0:57 ` [PATCH v4 12/14] ASoC: apq8096: add slim support srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 13/14] ASoC: apq8096: add headset JACK support srinivas.kandagatla
2018-09-17 0:57 ` [PATCH v4 14/14] ASoC: qcom: common: move be_hw_fixup to common srinivas.kandagatla
2018-09-19 5:49 ` [alsa-devel] " Rohit Kumar
2018-09-26 10:56 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8582abce-b1c8-24fc-7db2-b7101a6e1362@codeaurora.org \
--to=bgoswami@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).