From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753645AbeD3Lxq (ORCPT ); Mon, 30 Apr 2018 07:53:46 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:36463 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbeD3Lxn (ORCPT ); Mon, 30 Apr 2018 07:53:43 -0400 Subject: Re: [PATCH v3 4/6] rpmsg: Guard against null endpoint ops in destroy From: Arnaud Pouliquen To: Chris Lew , , , , , CC: , , , , , References: <1524783545-21951-1-git-send-email-clew@codeaurora.org> <1524783545-21951-5-git-send-email-clew@codeaurora.org> Message-ID: <85871a63-5e7c-9769-6a76-36b1cf44f59b@st.com> Date: Mon, 30 Apr 2018 13:53:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG4NODE1.st.com (10.75.127.10) To SFHDAG3NODE1.st.com (10.75.127.7) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-04-30_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2018 10:36 AM, Arnaud Pouliquen wrote: > Hello Chris, > > On 04/27/2018 12:59 AM, Chris Lew wrote: >> In RPMSG GLINK the chrdev device will allocate an ept as part of the >> rpdev creation. This device will not register endpoint ops even though >> it has an allocated ept. Protect against the case where the device is >> being destroyed. >> >> Signed-off-by: Chris Lew >> --- >> >> Changes since v1: >> - New change >> >> drivers/rpmsg/rpmsg_core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c >> index 920a02f0462c..7bfe36afccc5 100644 >> --- a/drivers/rpmsg/rpmsg_core.c >> +++ b/drivers/rpmsg/rpmsg_core.c >> @@ -88,7 +88,7 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev, >> */ >> void rpmsg_destroy_ept(struct rpmsg_endpoint *ept) >> { >> - if (ept) >> + if (ept && ept->ops) >> ept->ops->destroy_ept(ept); >> } >> EXPORT_SYMBOL(rpmsg_destroy_ept); >> > > Would make sense that you also add test on ept->ops->destroy_ept. I > guess that ops may not be null while destroy_ept pointer is. Sorry i cross checked in rpmsg_endpoint_ops. destroy_ept is required. So my comment is not relevant. Nevertheless do it make sense to have an endpoint without associated ops? I don't use rpmsg_char but I tried to figure out how rpmsg_create_ept is called in rpmsg_char without rpmsg_device ops... Seems that qcom_glink_create_ept should be called, so ept->ops should point to glink_endpoint_ops struct, right? Another point concerns the send and try send ops that are also required. Do you test rpmsg_trysend and/or rpmsg_send function call? seems that you should face the same issue... > > Regards > Arnaud > -- > To unsubscribe from this list: send the line "unsubscribe linux-remoteproc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >