From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-doc@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v3 04/15] ARM: dts: dra74x-mmc-iodelay: Add a new pinctrl group for clk line without pullup
Date: Fri, 27 Apr 2018 16:49:48 +0530 [thread overview]
Message-ID: <859a6ba4-3dd7-2507-d536-e6b559372f32@ti.com> (raw)
In-Reply-To: <20180425133529.GU5671@atomide.com>
Hi Tony,
On Wednesday 25 April 2018 07:05 PM, Tony Lindgren wrote:
> * Kishon Vijay Abraham I <kishon@ti.com> [180425 12:57]:
>> --- a/arch/arm/boot/dts/dra74x-mmc-iodelay.dtsi
>> +++ b/arch/arm/boot/dts/dra74x-mmc-iodelay.dtsi
>> @@ -49,6 +49,17 @@
>> >;
>> };
>>
>> + mmc1_pins_default_no_clk_pu: mmc1_pins_default_no_clk_pu {
>> + pinctrl-single,pins = <
>> + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */
>> + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
>> + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
>> + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
>> + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
>> + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
>> + >;
>> + };
>> +
>> mmc1_pins_sdr12: mmc1_pins_sdr12 {
>> pinctrl-single,pins = <
>> DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */
>> --
>
> If this data is the same for all of them, why don't you add something
> like dra7-iodelay.dtsi that can be included as needed?
okay, I'll add dra7-mmc-iodelay.dtsi and send a new revision.
Thanks
Kishon
next prev parent reply other threads:[~2018-04-27 11:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 12:54 [PATCH v3 00/15] dra7: mmc: Update mmc dt node to use sdhci-omap Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 01/15] ARM: dts: dra72-evm-common: Remove mmc specific pinmux Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 02/15] ARM: dts: dra71-evm: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 03/15] ARM: dts: dra72x-mmc-iodelay: Add a new pinctrl group for clk line without pullup Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 04/15] ARM: dts: dra74x-mmc-iodelay: " Kishon Vijay Abraham I
2018-04-25 13:35 ` Tony Lindgren
2018-04-27 11:19 ` Kishon Vijay Abraham I [this message]
2018-04-25 12:54 ` [PATCH v3 05/15] ARM: dts: dra76x-mmc-iodelay: " Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 06/15] ARM: dts: am57xx-idk: Use pinctrl group from dra7xx-mmc-iodelay.dtsi to select pulldown Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 07/15] ARM: dts: dra71-evm: Use pinctrl group from dra72x-mmc-iodelay.dtsi " Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 08/15] ARM: dts: am574x-idk: Add pinmux configuration for MMC Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 09/15] ARM: dts: dra72-evm-common: Add wilink8 wlan support Kishon Vijay Abraham I
2018-04-25 14:49 ` Rob Herring
2018-04-25 12:54 ` [PATCH v3 10/15] ARM: dts: dra7-evm: Model EVM_3V6 regulator Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 11/15] ARM: dts: dra7-evm: Add wilink8 wlan support Kishon Vijay Abraham I
2018-04-25 14:47 ` Rob Herring
2018-04-27 11:20 ` Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 12/15] ARM: dts: dra76-evm: " Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 13/15] ARM: dts: dra7: Use sdhci-omap programming model Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 14/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node Kishon Vijay Abraham I
2018-04-25 12:54 ` [PATCH v3 15/15] Documentation: ARM: Add new MMC requirements for DRA7/K2G Kishon Vijay Abraham I
2018-04-25 13:32 ` [PATCH v4 " Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=859a6ba4-3dd7-2507-d536-e6b559372f32@ti.com \
--to=kishon@ti.com \
--cc=bcousson@baylibre.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).