RE: [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO

["yuechao.zhao(赵越超)" <yuechao.zhao@advantech.com.cn>]

Hi Pavel
As for " Please Cc LED drivers to the LED maintainers...", does it mean that I only need to Cc LED drivers to LED maintainers?
Or do I need to send this driver to linux-leds@vger.kernel.org instead of platform-driver-x86@vger.kernel.org.

Best regards
Yuechao Zhao

-----Original Message-----
From: Pavel Machek [mailto:pavel@ucw.cz] 
Sent: Tuesday, April 27, 2021 9:54 PM
To: yuechao.zhao(赵越超) <yuechao.zhao@advantech.com.cn>
Cc: 345351830@qq.com; Rainbow.Zhang(張玉) <Rainbow.Zhang@advantech.com.cn>; yunxia.li(李云霞) <yunxia.li@advantech.com.cn>; Jia.Sui(贾睢) <Jia.Sui@advantech.com.cn>; Hans de Goede <hdegoede@redhat.com>; Mark Gross <mgross@linux.intel.com>; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
Subject: Re: [v2,1/1] adv_mix955x is a scheme that multiplexes PCA9554/PCA9555 into LED and GPIO

On Tue 2021-04-27 08:32:05, yuechao.zhao(赵越超) wrote:
> From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
> 
> With this driver, we can multiplex PCA9554/PCA9555 into LED and GPIO based on the ACPI data of BIOS.
> 
> Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
> Signed-off-by: Sui Jia <jia.sui@advantech.com.cn>

Please Cc LED drivers to the LED maintainers...

> +
> +static inline u8 amix955x_set_bit(u8 val, int led_id, enum 
> +AMIX955X_LED
> +state) {
> +	led_id %= BANK_SIZE;
> +
> +	switch (state) {
> +	case AMIX955X_LED_ON:
> +		val &= ~(1 << led_id); //Clear bit
> +		break;
> +	case AMIX955X_LED_OFF:
> +		val |= 1 << led_id; //Set bit
> +		break;
> +	}
> +
> +	return val;

Please check CodingStyle, avoid useless comments and check word wrapping in your email settings.

Best regards,
								Pavel

--
http://www.livejournal.com/~pavelmachek