From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbeEAKN3 (ORCPT ); Tue, 1 May 2018 06:13:29 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:37029 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbeEAKN1 (ORCPT ); Tue, 1 May 2018 06:13:27 -0400 Subject: Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect To: Boris Brezillon , Bartosz Golaszewski CC: Kevin Hilman , Russell King , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Tony Lindgren , Krzysztof Kozlowski , Bartosz Golaszewski , , Linux Kernel Mailing List , Linux ARM References: <20180430082453.8091-1-brgl@bgdev.pl> <20180430120930.4768a7cb@bbrezillon> <20180430184751.574550cc@bbrezillon> From: Sekhar Nori Message-ID: <859f5a71-d8c9-0a9c-f8e9-5194bf394960@ti.com> Date: Tue, 1 May 2018 15:42:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180430184751.574550cc@bbrezillon> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 30 April 2018 10:17 PM, Boris Brezillon wrote: > On Mon, 30 Apr 2018 18:45:06 +0200 > Bartosz Golaszewski wrote: > >> 2018-04-30 12:09 GMT+02:00 Boris Brezillon : >>> Hi Bartosz, >>> >>> On Mon, 30 Apr 2018 10:24:41 +0200 >>> Bartosz Golaszewski wrote: >>> >>>> From: Bartosz Golaszewski >>>> >>>> We have the 'ti,davinci-chipselect' property in the device tree, but >>>> when using platform data the driver silently uses the id field of >>>> struct platform_device as the chipselect. This is confusing and we >>>> almost broke the nand support again recently after converting the >>>> platform to common clock framework (which changed the device id in the >>>> clock lookup - the problem is gone now that we no longer acquire the >>>> clock in the nand driver. >>>> >>>> This series adds a new field to davinci-nand platform data, then makes >>>> all board use it and finally modifies the two drivers that make use of >>>> it. >>>> >>>> Bartosz Golaszewski (12): >>>> mtd: nand: davinci: store the core chipselect number in platform data >>> >>> Raw NAND related patches (that is, everything that is not onenand or >>> SPI NAND) should use the "mtd: rawnand: " prefix now. Other than that, >>> I'm fine with the patch series, just let me know how you want to have it >>> merged (through the MTD tree or the davinci tree). >>> >>> Thanks, >>> >>> Boris >> >> I think Sekhar could pick all those patches up for 4.18. > > Okay, then I'd need an immutable branch containing these changes. Boris, sure! > >> >> Sekhar - do you want me to resend the series with the commit message >> changed as requested by Boris, or can you fix it when applying the >> series? Bartosz, No need to resend. I also wanted couple of changes on 1/12 which I can do locally too. Thanks, Sekhar