From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Paul Boddie <paul@boddie.org.uk>,
Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paulburton@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Andi Kleen <ak@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-mips@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH v5 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600
Date: Tue, 3 Mar 2020 13:10:22 +0100 [thread overview]
Message-ID: <85F9D066-EAF6-4840-8F54-24E6D8A534DC@goldelico.com> (raw)
In-Reply-To: <20200303101818.GA12103@alpha.franken.de>
Hi Thomas,
> Am 03.03.2020 um 11:18 schrieb Thomas Bogendoerfer <tsbogend@alpha.franken.de>:
>
> On Sat, Feb 29, 2020 at 08:45:45PM +0100, H. Nikolaus Schaller wrote:
>> There is a ACT8600 on the CI20 board and the bindings of the
>> ACT8865 driver have changed without updating the CI20 device
>> tree. Therefore the PMU can not be probed successfully and
>> is running in power-on reset state.
>>
>> Fix DT to match the latest act8865-regulator bindings.
>>
>> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
>
> I see checkpatch warnings in this patch, could please fix them ?
Ah, ok. The comment. Well, on a 5k screen this 80 character limit
is really outdated. But checkpatch is the king :)
Noted for v6.
> And please seperate fixes from improvments, thank you.
What do you mean by "separate"? Two separate patches?
This patch only contains fixes (which I would consider
all of them to be improvements).
>
> Thomas.
BR and thanks,
Nikolaus
next prev parent reply other threads:[~2020-03-03 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 19:45 [PATCH v5 0/5] MIPS: Fixes and improvements for CI20 board (JZ4780) H. Nikolaus Schaller
2020-02-29 19:45 ` [PATCH v5 1/5] MIPS: DTS: CI20: add DT node for IR sensor H. Nikolaus Schaller
2020-02-29 19:45 ` [PATCH v5 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600 H. Nikolaus Schaller
2020-03-03 10:18 ` Thomas Bogendoerfer
2020-03-03 12:10 ` H. Nikolaus Schaller [this message]
2020-03-03 12:32 ` Thomas Bogendoerfer
2020-03-03 12:36 ` H. Nikolaus Schaller
2020-02-29 19:45 ` [PATCH v5 3/5] MIPS: DTS: CI20: fix interrupt for pcf8563 RTC H. Nikolaus Schaller
2020-02-29 19:45 ` [PATCH v5 4/5] MIPS: DTS: CI20: multiple DTS improvements H. Nikolaus Schaller
2020-02-29 19:45 ` [PATCH v5 5/5] MIPS: CI20: defconfig: multiple improvements H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85F9D066-EAF6-4840-8F54-24E6D8A534DC@goldelico.com \
--to=hns@goldelico.com \
--cc=ak@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=geert+renesas@glider.be \
--cc=keescook@chromium.org \
--cc=krzk@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).