From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7FBC433E0 for ; Thu, 7 Jan 2021 09:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F2F72333C for ; Thu, 7 Jan 2021 09:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727237AbhAGJUQ (ORCPT ); Thu, 7 Jan 2021 04:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbhAGJUP (ORCPT ); Thu, 7 Jan 2021 04:20:15 -0500 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B59EC0612F5 for ; Thu, 7 Jan 2021 01:19:35 -0800 (PST) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2FFCF22FFC; Thu, 7 Jan 2021 10:19:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1610011169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3lkymuyrUAi4MoR91Xr/Qm8hIvl1yFt2zm4h2BQJRI4=; b=hpSdZyIcxfnahmDkdlQ6y/os8qYzqZJkEqqMZnfMTz2GrOzX/OA3Pq7LC3xS6mXxqA8R4j imp82yOpgH5ETCX+v5PgnEE92XfVqe7v7lQOLLOZUqEKSbugTJt7W6nQZOjAR4D1Dh2cyz gVW+kqa/cAGjEVKyBCEl7MJJB1o3zdw= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 07 Jan 2021 10:19:28 +0100 From: Michael Walle To: Greg Kroah-Hartman Cc: Saravana Kannan , "Rafael J. Wysocki" , kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] driver core: Fix device link device name collision In-Reply-To: References: <20210106232641.459081-1-saravanak@google.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <85acc1d3523a3c6f88687d3491f83380@walle.cc> X-Sender: michael@walle.cc Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2021-01-07 10:00, schrieb Greg Kroah-Hartman: > On Wed, Jan 06, 2021 at 03:26:41PM -0800, Saravana Kannan wrote: >> The device link device's name was of the form: >> -- >> >> This can cause name collision as reported here [1] as device names are >> not globally unique. Since device names have to be unique within the >> bus/class, add the bus/class name as a prefix to the device names used >> to >> construct the device link device name. >> >> So the devuce link device's name will be of the form: >> :-- > > Minor nit, you forgot a ':' in the consumer side of the link here. The > code is correct. > >> >> [1] - >> https://lore.kernel.org/lkml/20201229033440.32142-1-michael@walle.cc/ >> Reported-by: Michael Walle >> Signed-off-by: Saravana Kannan >> --- >> >> Michael, >> >> Can you please test this? This should fix your issue. >> >> Having said that, do you have some local DT changes when you are >> testing >> this? Because it's not obvious from the DT in upstream what dependency >> is even being derived from the firmware. I don't see any dependency in >> upstream DT files between mdio_bus/0000:00:00.1 and >> pci0000:00/0000:00:00.1 > > That looks really odd, why is the mdio bus using the same names as the > pci bus? Logically the MDIO bus belongs to the ENETC, although its actually an own PCI device [1]. What do you think its name should be? > But anyway, your dev_bus_name() change here looks good, I'll take that > as a separate patch no matter what happens here :) I'm just testing this patch, looks like it doesn't fix it for now. But anyways. Shouldn't there be a Fixes tag for this patch? I.e. 5.11 is broken right now. [1] https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/freescale/enetc/enetc_pf.c#L748 -michael