From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C10CDB47E for ; Wed, 18 Oct 2023 05:49:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344424AbjJRFt2 (ORCPT ); Wed, 18 Oct 2023 01:49:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjJRFt0 (ORCPT ); Wed, 18 Oct 2023 01:49:26 -0400 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01329BA for ; Tue, 17 Oct 2023 22:49:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=6UsnL94RoCPgeTX9ccivn8yeLwPhEKD4FoOoPKRV430=; b=ZU7HGQjbE8tnfSJZSD2Jp1UwDXjoEi8OiEjyY1hZihrJ6bz4RgD7QSk3 GTFUT1O4HHTuCKKtkWO7KDnWIhBwBFDfUC5cEKCqdiJWu5VuHC5vzVZpO HVrJlKGX6u62byQfMcQaL1spy0x5tkSip0IchcY/c5KLk+coPaT4gDTYY k=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.03,234,1694728800"; d="scan'208";a="69015402" Received: from unknown (HELO hadrien) ([87.129.180.234]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2023 07:49:23 +0200 Date: Wed, 18 Oct 2023 07:49:22 +0200 (CEST) From: Julia Lawall To: Soumya Negi cc: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 0/2] staging: vme_user: Replace printk's & cleanup log messages In-Reply-To: Message-ID: <85af8b2d-6246-46c5-c6dc-582807010fa@inria.fr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Oct 2023, Soumya Negi wrote: > Staging driver vme_user has a bunch of printk() calls in vme.c which > triggers checkpatch warnings. Remove all printk's and change them to > the appropriate logging mechanism i.e pr_err()/pr_warn(), or > dev_err()/dev_warn(). > > Also, cleanup the messages further by using __func__ in the string > instead of function names. "cleanup" is not actually a verb. It's a noun. The verb would be clean up. julia > > This patchset fixes all checkpatch warnings like: > > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then > dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... > & > WARNING: Prefer using '"%s...", __func__' to using 'vme_lm_get', > this function's name, in a string > > Patches must be applied in order. > > Soumya Negi (2): > staging: vme_user: Replace printk() with pr_*(),dev_*() > staging: vme_user: Use __func__ instead of function name > > drivers/staging/vme_user/vme.c | 175 ++++++++++++++++++--------------- > 1 file changed, 94 insertions(+), 81 deletions(-) > > -- > 2.42.0 > > >