From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F0FC3A5A2 for ; Tue, 3 Sep 2019 19:52:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3621920882 for ; Tue, 3 Sep 2019 19:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbfICTwH convert rfc822-to-8bit (ORCPT ); Tue, 3 Sep 2019 15:52:07 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:38940 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725953AbfICTwH (ORCPT ); Tue, 3 Sep 2019 15:52:07 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 6D44028B13F From: Gabriel Krisman Bertazi To: Krzysztof Wilczynski Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] unicode: Move static keyword to the front of declarations Organization: Collabora References: <20190830131349.14074-1-kw@linux.com> Date: Tue, 03 Sep 2019 15:52:01 -0400 In-Reply-To: <20190830131349.14074-1-kw@linux.com> (Krzysztof Wilczynski's message of "Fri, 30 Aug 2019 15:13:49 +0200") Message-ID: <85blw1gntq.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Krzysztof Wilczynski writes: > Move the static keyword to the front of declarations of nfdi_test_data > and nfdicf_test_data, and resolve the following compiler warnings that > can be seen when building with warnings enabled (W=1): > > fs/unicode/utf8-selftest.c:38:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > fs/unicode/utf8-selftest.c:92:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > Applied. Thanks, -- Gabriel Krisman Bertazi