From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>, Lokesh Vutla <lokeshvutla@ti.com>
Cc: <daniel.lezcano@linaro.org>, Tero Kristo <t-kristo@ti.com>,
Sekhar Nori <nsekhar@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: Do one override clock parent in prepare()
Date: Tue, 5 May 2020 11:07:34 -0500 [thread overview]
Message-ID: <85caf769-08c5-7199-df46-5086428a6bf6@ti.com> (raw)
In-Reply-To: <20200428182209.GT37466@atomide.com>
On 4/28/20 1:22 PM, Tony Lindgren wrote:
> * Lokesh Vutla <lokeshvutla@ti.com> [200427 17:29]:
>> omap_dm_timer_prepare() is setting up the parent 32KHz clock. This
>> prepare() gets called by request_timer in the client's driver. Because of
>> this, the timer clock parent that is set with assigned-clock-parent is being
>> overwritten. So drop this default setting of parent in prepare().
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Reviewed-by: Suman Anna <s-anna@ti.com>
>
> This works just fine for me but depends on the dts changes.
>
> Daniel, for merging, do you want to set up an immutable branch
> for the related dts change and this? I'm afraid it will conflict
> with the related systimer changes for the dts otherwise.
>
> Regards,
>
> Tony
>
>> ---
>> - As per the discussion happened here[0], dropping the default setting.
>> [0] https://patchwork.kernel.org/patch/11379875/#23309493
>>
>> drivers/clocksource/timer-ti-dm.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
>> index 2531eab3d6d7..60aff087947a 100644
>> --- a/drivers/clocksource/timer-ti-dm.c
>> +++ b/drivers/clocksource/timer-ti-dm.c
>> @@ -258,9 +258,7 @@ static int omap_dm_timer_prepare(struct omap_dm_timer *timer)
>> __omap_dm_timer_enable_posted(timer);
>> omap_dm_timer_disable(timer);
>>
>> - rc = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
>> -
>> - return rc;
>> + return 0;
>> }
>>
>> static inline u32 omap_dm_timer_reserved_systimer(int id)
>> --
>> 2.23.0
>>
next prev parent reply other threads:[~2020-05-05 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 17:28 [PATCH] clocksource/drivers/timer-ti-dm: Do one override clock parent in prepare() Lokesh Vutla
2020-04-28 18:22 ` Tony Lindgren
2020-05-05 16:07 ` Suman Anna [this message]
2020-05-05 18:07 ` Tony Lindgren
2020-05-20 9:03 ` Daniel Lezcano
2020-06-01 13:11 ` [tip: timers/core] " tip-bot2 for Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85caf769-08c5-7199-df46-5086428a6bf6@ti.com \
--to=s-anna@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).