From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Bob Liu <bob.liu@oracle.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, axboe@kernel.dk, tytso@mit.edu,
adilger.kernel@dilger.ca, Chaitanya.Kulkarni@wdc.com,
darrick.wong@oracle.com, ming.lei@redhat.com, osandov@fb.com,
jthumshirn@suse.de, minwoo.im.dev@gmail.com,
damien.lemoal@wdc.com, andrea.parri@amarulasolutions.com,
hare@suse.com, tj@kernel.org, ajay.joshi@wdc.com,
sagi@grimberg.me, dsterba@suse.com, bvanassche@acm.org,
dhowells@redhat.com, asml.silence@gmail.com
Subject: Re: [PATCH block v2 1/3] block: Add @flags argument to bdev_write_zeroes_sectors()
Date: Mon, 20 Jan 2020 14:11:43 +0300 [thread overview]
Message-ID: <85d0dcea-d151-18e9-cb7a-8b277d168bc7@virtuozzo.com> (raw)
In-Reply-To: <a8c5c5fd-d6b1-950e-0493-b5020e5ca87d@oracle.com>
On 19.01.2020 04:46, Bob Liu wrote:
> On 1/16/20 8:35 PM, Kirill Tkhai wrote:
>> This is a preparation for next patch, which introduces
>> a new flag BLKDEV_ZERO_ALLOCATE for calls, which need
>> only allocation of blocks and don't need actual blocks
>> zeroing.
>>
>> CC: Martin K. Petersen <martin.petersen@oracle.com>
>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>> ---
>> block/blk-lib.c | 6 +++---
>> drivers/md/dm-kcopyd.c | 2 +-
>> drivers/target/target_core_iblock.c | 4 ++--
>> include/linux/blkdev.h | 3 ++-
>> 4 files changed, 8 insertions(+), 7 deletions(-)
>>
>
> Looks good to me.
> Reviewed-by: Bob Liu <bob.liu@oracle.com>
Thanks, Bob.
>> diff --git a/block/blk-lib.c b/block/blk-lib.c
>> index 5f2c429d4378..3e38c93cfc53 100644
>> --- a/block/blk-lib.c
>> +++ b/block/blk-lib.c
>> @@ -224,7 +224,7 @@ static int __blkdev_issue_write_zeroes(struct block_device *bdev,
>> return -EPERM;
>>
>> /* Ensure that max_write_zeroes_sectors doesn't overflow bi_size */
>> - max_write_zeroes_sectors = bdev_write_zeroes_sectors(bdev);
>> + max_write_zeroes_sectors = bdev_write_zeroes_sectors(bdev, 0);
>>
>> if (max_write_zeroes_sectors == 0)
>> return -EOPNOTSUPP;
>> @@ -362,7 +362,7 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
>> sector_t bs_mask;
>> struct bio *bio;
>> struct blk_plug plug;
>> - bool try_write_zeroes = !!bdev_write_zeroes_sectors(bdev);
>> + bool try_write_zeroes = !!bdev_write_zeroes_sectors(bdev, 0);
>>
>> bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1;
>> if ((sector | nr_sects) & bs_mask)
>> @@ -391,7 +391,7 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
>> try_write_zeroes = false;
>> goto retry;
>> }
>> - if (!bdev_write_zeroes_sectors(bdev)) {
>> + if (!bdev_write_zeroes_sectors(bdev, 0)) {
>> /*
>> * Zeroing offload support was indicated, but the
>> * device reported ILLEGAL REQUEST (for some devices
>> diff --git a/drivers/md/dm-kcopyd.c b/drivers/md/dm-kcopyd.c
>> index 1bbe4a34ef4c..f1b8e7926dd4 100644
>> --- a/drivers/md/dm-kcopyd.c
>> +++ b/drivers/md/dm-kcopyd.c
>> @@ -831,7 +831,7 @@ void dm_kcopyd_copy(struct dm_kcopyd_client *kc, struct dm_io_region *from,
>> */
>> job->rw = REQ_OP_WRITE_ZEROES;
>> for (i = 0; i < job->num_dests; i++)
>> - if (!bdev_write_zeroes_sectors(job->dests[i].bdev)) {
>> + if (!bdev_write_zeroes_sectors(job->dests[i].bdev, 0)) {
>> job->rw = WRITE;
>> break;
>> }
>> diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c
>> index 51ffd5c002de..73a63e197bf5 100644
>> --- a/drivers/target/target_core_iblock.c
>> +++ b/drivers/target/target_core_iblock.c
>> @@ -117,7 +117,7 @@ static int iblock_configure_device(struct se_device *dev)
>> * Enable write same emulation for IBLOCK and use 0xFFFF as
>> * the smaller WRITE_SAME(10) only has a two-byte block count.
>> */
>> - max_write_zeroes_sectors = bdev_write_zeroes_sectors(bd);
>> + max_write_zeroes_sectors = bdev_write_zeroes_sectors(bd, 0);
>> if (max_write_zeroes_sectors)
>> dev->dev_attrib.max_write_same_len = max_write_zeroes_sectors;
>> else
>> @@ -468,7 +468,7 @@ iblock_execute_write_same(struct se_cmd *cmd)
>> return TCM_INVALID_CDB_FIELD;
>> }
>>
>> - if (bdev_write_zeroes_sectors(bdev)) {
>> + if (bdev_write_zeroes_sectors(bdev, 0)) {
>> if (!iblock_execute_zero_out(bdev, cmd))
>> return 0;
>> }
>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
>> index c45779f00cbd..4cd69552df9a 100644
>> --- a/include/linux/blkdev.h
>> +++ b/include/linux/blkdev.h
>> @@ -1418,7 +1418,8 @@ static inline unsigned int bdev_write_same(struct block_device *bdev)
>> return 0;
>> }
>>
>> -static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev)
>> +static inline unsigned int bdev_write_zeroes_sectors(struct block_device *bdev,
>> + unsigned int flags)
>> {
>> struct request_queue *q = bdev_get_queue(bdev);
>>
>>
>>
>
next prev parent reply other threads:[~2020-01-20 11:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:35 [PATCH block v2 0/3] block: Introduce REQ_NOZERO flag for REQ_OP_WRITE_ZEROES operation Kirill Tkhai
2020-01-16 12:35 ` [PATCH block v2 1/3] block: Add @flags argument to bdev_write_zeroes_sectors() Kirill Tkhai
2020-01-19 1:46 ` Bob Liu
2020-01-20 11:11 ` Kirill Tkhai [this message]
2020-01-21 5:45 ` Martin K. Petersen
2020-01-16 12:36 ` [PATCH block v2 2/3] block: Add support for REQ_NOZERO flag Kirill Tkhai
2020-01-19 1:50 ` Bob Liu
2020-01-20 10:02 ` Kirill Tkhai
2020-01-21 6:13 ` Bob Liu
2020-01-21 9:45 ` Kirill Tkhai
2020-01-21 6:14 ` Martin K. Petersen
2020-01-21 9:47 ` Kirill Tkhai
2020-01-31 6:23 ` Christoph Hellwig
2020-01-31 9:15 ` Kirill Tkhai
2020-01-16 12:36 ` [PATCH block v2 3/3] loop: Add support for REQ_NOZERO Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d0dcea-d151-18e9-cb7a-8b277d168bc7@virtuozzo.com \
--to=ktkhai@virtuozzo.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=adilger.kernel@dilger.ca \
--cc=ajay.joshi@wdc.com \
--cc=andrea.parri@amarulasolutions.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=hare@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).