From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC31C004D3 for ; Mon, 22 Oct 2018 10:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B151920853 for ; Mon, 22 Oct 2018 10:43:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="SLZmQe7J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B151920853 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbeJVTBX (ORCPT ); Mon, 22 Oct 2018 15:01:23 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:55330 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbeJVTBX (ORCPT ); Mon, 22 Oct 2018 15:01:23 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id w9MAgrgM046259; Mon, 22 Oct 2018 05:42:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1540204973; bh=kdBq+yXBgAAuel44EEWpMCJOplNKtiBudVeXT8ml7dg=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=SLZmQe7JTp5k19qgrUVM06fejykHoXScwxtMlY18HQ1MJ5mPda8gmDA8dM5xRZFvS Avn1sgnqO/XzirM1xWlKwnPGCQVRRVA0qGUIcXsMIff2qET6fjGhfK8bQqmjKBi/yl dG/BQWEhOfg+c9UwIBoo8ichQnpOBbiIuJV3AN2Y= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9MAgqUX028647; Mon, 22 Oct 2018 05:42:52 -0500 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 22 Oct 2018 05:42:52 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Mon, 22 Oct 2018 05:42:52 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w9MAgnLr031994; Mon, 22 Oct 2018 05:42:50 -0500 Subject: Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver From: Peter Ujfalusi To: Lokesh Vutla , Nishanth Menon , Santosh Shilimkar , Rob Herring , , , CC: Device Tree Mailing List , Grygorii Strashko , Sekhar Nori , , Tero Kristo , Linux ARM Mailing List References: <20181018154017.7112-1-lokeshvutla@ti.com> <20181018154017.7112-10-lokeshvutla@ti.com> <6b112f34-cae3-fcd4-0d36-80b39c575fe4@ti.com> Message-ID: <85ec72c9-1b5b-6621-a704-c12efe6d72a7@ti.com> Date: Mon, 22 Oct 2018 13:43:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6b112f34-cae3-fcd4-0d36-80b39c575fe4@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-10-22 13:42, Peter Ujfalusi wrote: > Lokesh, > > On 2018-10-18 18:40, Lokesh Vutla wrote: >> Texas Instruments' K3 generation SoCs has an IP Interrupt Aggregator >> which is an interrupt controller that does the following: >> - Converts events to interrupts that can be understood by >> an interrupt router. >> - Allows for multiplexing of events to interrupts. >> - Allows for grouping of multiple events to a single interrupt. >> >> Configuration of the interrupt aggregator registers can only be done by >> a system co-processor and the driver needs to send a message to this >> co processor over TISCI protocol. >> >> Add support for Interrupt Aggregator driver over TISCI protocol. > > Have you compiled this? > > ... > >> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c >> new file mode 100644 >> index 000000000000..ef0a2e8b782c >> --- /dev/null >> +++ b/drivers/irqchip/irq-ti-sci-inta.c > > ... > >> +/** >> + * ti_sci_inta_register_event() - Register a event to an interrupt aggregator >> + * @dev: Device pointer to source generating the event >> + * @src_id: TISCI device ID of the event source >> + * @src_index: Event source index within the device. >> + * @virq: Linux Virtual IRQ number >> + * @flags: Corresponding IRQ flags >> + * @ack_needed: If explicit clearing of event is required. >> + * >> + * Creates a new irq and attaches to IA domain if virq is not specified >> + * else attaches the event to vint corresponding to virq. >> + * When using TISCI within the client drivers, source indexes are always >> + * generated dynamically and cannot be represented in DT. So client >> + * drivers should call this API instead of platform_get_irq(). >> + * >> + * Return virq if all went well else appropriate error value. >> + */ >> +int ti_sci_inta_register_event(struct device *dev, u16 src_id, u16 src_index, >> + unsigned int virq, u32 flags, bool ack_needed) And can you swap the flags and ack_needed? >> +{ > > ... > >> diff --git a/include/linux/irqchip/irq-ti-sci-inta.h b/include/linux/irqchip/irq-ti-sci-inta.h >> new file mode 100644 >> index 000000000000..c078234fda3f >> --- /dev/null >> +++ b/include/linux/irqchip/irq-ti-sci-inta.h >> @@ -0,0 +1,35 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +/* >> + * Texas Instruments' System Control Interface (TI-SCI) irqchip >> + * >> + * Copyright (C) 2018 Texas Instruments Incorporated - http://www.ti.com/ >> + * Lokesh Vutla >> + */ >> + >> +#ifndef __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H >> +#define __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H >> + >> +#if IS_ENABLED(CONFIG_TI_SCI_INTA_IRQCHIP) >> +int ti_sci_inta_register_event(struct device *dev, u16 src_id, u16 src_index, >> + unsigned int virq, u32 flags); > > You are missing the ack_needed > >> +int ti_sci_inta_unregister_event(struct device *dev, u16 src_id, u16 src_index, >> + unsigned int virq); >> + >> +#else /* CONFIG_TI_SCI_INTA_IRQCHIP */ >> + >> +static inline int ti_sci_inta_register_event(struct device *dev, u16 src_id, >> + u16 src_index, unsigned int virq, >> + u32 flags) > > Here as well. > >> +{ >> + return -EINVAL; >> +} >> + >> +static inline int ti_sci_inta_unregister_event(struct device *dev, u16 src_id, >> + u16 src_index, unsigned int virq) >> +{ >> + return -EINVAL; >> +} >> + >> +#endif /* CONFIG_TI_SCI_INTA_IRQCHIP */ >> + >> +#endif /* __INCLUDE_LINUX_IRQCHIP_TI_SCI_INTA_H */ >> > > - Péter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki