From: Neeraj Upadhyay <neeraju@codeaurora.org>
To: Mark Rutland <mark.rutland@arm.com>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Marc Zyngier <maz@kernel.org>,
sudeep.holla@arm.com
Cc: suzuki.poulose@arm.com, ionela.voinescu@arm.com,
MSM <linux-arm-msm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
catalin.marinas@arm.com, Will Deacon <will@kernel.org>,
valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: AMU extension v1 support for cortex A76, A77, A78 CPUs
Date: Tue, 24 Nov 2020 10:52:15 +0530 [thread overview]
Message-ID: <8606d7f9-bd3d-c825-3f38-d48879be59f9@codeaurora.org> (raw)
In-Reply-To: <20201120101249.GA2328@C02TD0UTHF1T.local>
Thanks Marc, Vladimir, Mark, Sudeep for your inputs!
Thanks
Neeraj
On 11/20/2020 3:43 PM, Mark Rutland wrote:
> On Fri, Nov 20, 2020 at 09:09:00AM +0000, Vladimir Murzin wrote:
>> On 11/20/20 8:56 AM, Marc Zyngier wrote:
>>> On 2020-11-20 04:30, Neeraj Upadhyay wrote:
>>>> Hi,
>>>>
>>>> For ARM cortex A76, A77, A78 cores (which as per TRM, support AMU)
>>>> AA64PFR0[47:44] field is not set, and AMU does not get enabled for
>>>> them.
>>>> Can you please provide support for these CPUs in cpufeature.c?
>>>
>>> If that was the case, that'd be an erratum, and it would need to be
>>> documented as such. It could also be that this is an optional feature
>>> for these cores (though the TRM doesn't suggest that).
>>>
>>> Can someone at ARM confirm what is the expected behaviour of these CPUs?
>>
>> Not a confirmation, but IIRC, these are imp def features, while our cpufeatures
>> catches architected one.
>
> We generally don't make use of IMP-DEF featurees because of all the pain
> it brings.
>
> Looking at the Cortex-A76 TRM, the encoding for AMCNTENCLR is:
>
> Op0: 3 (0b11)
> Op1: 3 (0b011)
> CRn: 15 (0b1111)
> CRm: 9 (0b1001)
> Op2: 7 (0b111)
>
> ... whereas the architected encoding (from our sysreg.h) is:
>
> Op0: 3
> Op1: 3
> CRn: 13
> CRm: 2
> Op2: 4
>
> ... so that's a different register with the same name, which is
> confusing and unfortunate.
>
> The encodings are different (and I haven't checked whether the fields /
> semantics are the same), so it's not just a matter of wiring up new
> detection code. There are also IMP-DEF traps in ACTLR_EL3 and ACTLR_EL2
> which we can't be certain of the configuration of, and as the registers
> are in the IMP-DEF encoding space they'll be trapped by HCR_EL2.TIDCP
> and emulated as UNDEFINED by a hypervisor. All of that means that going
> by the MIDR alone is not sufficient to know we can safely access the
> registers.
>
> So as usual for IMP-DEF stuff I don't think we can or should make use of
> this.
>
> Thanks,
> Mark.
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-11-24 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 4:30 AMU extension v1 support for cortex A76, A77, A78 CPUs Neeraj Upadhyay
2020-11-20 8:56 ` Marc Zyngier
2020-11-20 9:09 ` Vladimir Murzin
2020-11-20 9:54 ` Marc Zyngier
2020-11-20 10:14 ` Vladimir Murzin
2020-11-20 10:13 ` Mark Rutland
2020-11-24 5:22 ` Neeraj Upadhyay [this message]
2020-11-20 10:20 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8606d7f9-bd3d-c825-3f38-d48879be59f9@codeaurora.org \
--to=neeraju@codeaurora.org \
--cc=catalin.marinas@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).