From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Brian Norris <briannorris@chromium.org>,
Olof Johansson <olof@lixom.net>,
Benson Leung <bleung@chromium.org>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
Brian Norris <computersforpeace@gmail.com>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Subject: Re: [PATCH v2] platform/chrome: Use proper protocol transfer function
Date: Tue, 29 Nov 2016 09:20:10 -0300 [thread overview]
Message-ID: <8610e219-8b9a-3010-70b7-b43aaef7cf2b@osg.samsung.com> (raw)
In-Reply-To: <1480371552-58960-1-git-send-email-briannorris@chromium.org>
Hello Brian,
On 11/28/2016 07:19 PM, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@chromium.org>
>
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
>
That's correct, sorry for missing this when pushing the patch to mainline.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2016-11-29 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 22:19 [PATCH v2] platform/chrome: Use proper protocol transfer function Brian Norris
2016-11-29 12:20 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8610e219-8b9a-3010-70b7-b43aaef7cf2b@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).