From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF08C2D0C0 for ; Sun, 22 Dec 2019 12:10:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC724206D3 for ; Sun, 22 Dec 2019 12:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577016657; bh=FKzfMZXGIg0MWn2kAMDfixcbn7XSFoAYPtS1Bu8cuPo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=G9k066nk/+JC64Y/juIWRqgtvn+3Pjx0XiCRfjJIMOPDx23nGiMgSrrBr+rg5hhh/ +JRR+9VPa1vvZxdAtbe/pPoZBXyQ3HY+HVh83dFHU9xP+gJ/A8qg753E+lJFHPfGaK K4fURogvhxuODsxOhXiFWf+6QyxG+RQBt7CD50sQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726679AbfLVMK4 (ORCPT ); Sun, 22 Dec 2019 07:10:56 -0500 Received: from inca-roads.misterjones.org ([213.251.177.50]:36670 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfLVMK4 (ORCPT ); Sun, 22 Dec 2019 07:10:56 -0500 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1ij04T-0007sI-T2; Sun, 22 Dec 2019 13:10:54 +0100 Date: Sun, 22 Dec 2019 12:10:52 +0000 Message-ID: <865zi8imr7.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Murray Cc: Marc Zyngier , Catalin Marinas , Will Deacon , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 15/18] perf: arm_spe: Handle guest/host exclusion flags In-Reply-To: <20191220143025.33853-16-andrew.murray@arm.com> References: <20191220143025.33853-1-andrew.murray@arm.com> <20191220143025.33853-16-andrew.murray@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: andrew.murray@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Dec 2019 14:30:22 +0000, Andrew Murray wrote: > > A side effect of supporting the SPE in guests is that we prevent the > host from collecting data whilst inside a guest thus creating a black-out > window. This occurs because instead of emulating the SPE, we share it > with our guests. > > Let's accurately describe our capabilities by using the perf exclude > flags to prevent !exclude_guest and exclude_host flags from being used. > > Signed-off-by: Andrew Murray > --- > drivers/perf/arm_spe_pmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c > index 2d24af4cfcab..3703dbf459de 100644 > --- a/drivers/perf/arm_spe_pmu.c > +++ b/drivers/perf/arm_spe_pmu.c > @@ -679,6 +679,9 @@ static int arm_spe_pmu_event_init(struct perf_event *event) > if (attr->exclude_idle) > return -EOPNOTSUPP; > > + if (!attr->exclude_guest || attr->exclude_host) > + return -EOPNOTSUPP; > + I have the opposite approach. If the host decides to profile the guest, why should that be denied? If there is a black hole, it should take place in the guest. Today, the host does expect this to work, and there is no way that we unconditionally allow it to regress. M. -- Jazz is not dead, it just smells funny.