From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B63C433F5 for ; Tue, 28 Aug 2018 08:58:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31BE22089F for ; Tue, 28 Aug 2018 08:58:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31BE22089F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727576AbeH1Msr (ORCPT ); Tue, 28 Aug 2018 08:48:47 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:33654 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726954AbeH1Msq (ORCPT ); Tue, 28 Aug 2018 08:48:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61754ED1; Tue, 28 Aug 2018 01:58:07 -0700 (PDT) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 61AAA3F721; Tue, 28 Aug 2018 01:58:05 -0700 (PDT) Date: Tue, 28 Aug 2018 09:58:02 +0100 Message-ID: <865zzuyijp.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Jia He , Thomas Gleixner Cc: Jason Cooper , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jia He Subject: Re: [PATCH] irqchip/gic-v3-its: cap lpi_id_bits to reduce memory footprint In-Reply-To: <1535432006-2304-1-git-send-email-jia.he@hxt-semitech.com> References: <1535432006-2304-1-git-send-email-jia.he@hxt-semitech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Aug 2018 05:53:26 +0100, Jia He wrote: > > In commit fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs"), > it removes the cap for lpi_id_bits. But it will cause more pointless > memory footprint. > > There is a WARN_ON when my QDF2400 server boots up (pagesize is 4k) > ============begin=============== [trimming not-so-useful trace] > ============end============ > > In its_alloc_lpi_tables, lpi_id_bits is 24 in QDF2400. Then > its_allocate_prop_table will try to allocate 16M(order 12 if > pagesize=4k). Thus it causes the WARN_ON. > > As said by Marc, > Capping lpi_id_bits at 16 (which is what we had before) is plenty, > will save a some memory, and gives some margin before we need to push > it up again. > > This patch re-caps the lpi_id_bits. > > Fixes: fe8e93504ce8 ("irqchip/gic-v3-its: Use full range of LPIs") > Signed-off-by: Jia He > Suggested-by: Marc Zyngier Thanks for doing this. Small problem with this patch: The email comes from hejianet@gmail.com, while the sign off is by jia.he@hxt-semitech.com. Your email should start with a: From: Jia He Other than that: Acked-by: Marc Zyngier Thomas, would you mind picking this up so that it gets into the next convenient -rc? Thanks, M. (/me goes back hiking...) -- Jazz is not dead, it just smell funny.