From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbdHGHqt (ORCPT ); Mon, 7 Aug 2017 03:46:49 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:18533 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdHGHqq (ORCPT ); Mon, 7 Aug 2017 03:46:46 -0400 From: "Reizer, Eyal" To: Tony Lindgren CC: Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sebastian.reichel@collabora.co.uk" , Julian Calaby Subject: RE: [v5] wlcore: add missing nvs file name info for wilink8 Thread-Topic: [v5] wlcore: add missing nvs file name info for wilink8 Thread-Index: AQHTD060+De/O1l7k0qIxn3pSBkCZqJ4fueA///hL4CAACHIcA== Date: Mon, 7 Aug 2017 07:46:34 +0000 Message-ID: <8665E2433BC68541A24DFFCA87B70F5B3641E339@DFRE01.ent.ti.com> References: <1502090869-8833-1-git-send-email-eyalr@ti.com> <8665E2433BC68541A24DFFCA87B70F5B3641E25B@DFRE01.ent.ti.com> <20170807073808.GD5487@atomide.com> In-Reply-To: <20170807073808.GD5487@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.167.188.93] x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v777kxff016332 Hi Tony, > > * Reizer, Eyal [170807 00:32]: > > The following commits: > > c815fde wlcore: spi: Populate config firmware data > > d776fc8 wlcore: sdio: Populate config firmware data > > > > Populated the nvs entry for wilink6 and wilink7 only while it is > > still needed for wilink8 as well. > > This broke user space backward compatibility when upgrading from older > > kernels, as the alternate mac address would not be read from the nvs that > is > > present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin) > > causing mac address change of the wlan interface. > > > > This patch fix this and update the structure field with the same default > > nvs file name that has been used before. > > > > In addition, some distros hold a default wl1271-nvs.bin in the file > > system with a bogus mac address (deadbeef...) that for a wl18xx device > > also overrides the mac address that is stored inside the device. > > Warn users about this bogus mac address and use a random mac instead > > Hmm looks pretty good to me except for one more thing I just noticed. > > Why don't you just use the hardware mac address instead of a random > mac address on wl18xx device when you see a bogus nvs file? > I agree that this would have been better but the problem is that hardware mac address is available for wilink8 onlyWilink6/7 don't have one stored. The wlcore code responsible for handling mac address is common code and there is method for detecting between them in this module. Best Regards, Eyal