From: "Reizer, Eyal" <eyalr@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"sebastian.reichel@collabora.co.uk"
<sebastian.reichel@collabora.co.uk>,
Julian Calaby <julian.calaby@gmail.com>
Subject: RE: [v5] wlcore: add missing nvs file name info for wilink8
Date: Tue, 8 Aug 2017 08:03:55 +0000 [thread overview]
Message-ID: <8665E2433BC68541A24DFFCA87B70F5B3641F73A@DFRE01.ent.ti.com> (raw)
In-Reply-To: <20170808042054.GI5190@atomide.com>
> Subject: Re: [v5] wlcore: add missing nvs file name info for wilink8
>
> * Reizer, Eyal <eyalr@ti.com> [170807 00:47]:
> > Hi Tony,
> > >
> > > * Reizer, Eyal <eyalr@ti.com> [170807 00:32]:
> > > > The following commits:
> > > > c815fde wlcore: spi: Populate config firmware data
> > > > d776fc8 wlcore: sdio: Populate config firmware data
> > > >
> > > > Populated the nvs entry for wilink6 and wilink7 only while it is
> > > > still needed for wilink8 as well.
> > > > This broke user space backward compatibility when upgrading from
> older
> > > > kernels, as the alternate mac address would not be read from the nvs
> that
> > > is
> > > > present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin)
> > > > causing mac address change of the wlan interface.
> > > >
> > > > This patch fix this and update the structure field with the same default
> > > > nvs file name that has been used before.
> > > >
> > > > In addition, some distros hold a default wl1271-nvs.bin in the file
> > > > system with a bogus mac address (deadbeef...) that for a wl18xx device
> > > > also overrides the mac address that is stored inside the device.
> > > > Warn users about this bogus mac address and use a random mac
> instead
> > >
> > > Hmm looks pretty good to me except for one more thing I just noticed.
> > >
> > > Why don't you just use the hardware mac address instead of a random
> > > mac address on wl18xx device when you see a bogus nvs file?
> > >
> >
> > I agree that this would have been better but the problem is that hardware
> > mac address is available for wilink8 onlyWilink6/7 don't have one stored.
> > The wlcore code responsible for handling mac address is common code
> > and there is method for detecting between them in this module.
>
> Care to clarify a bit.. Are you saying wilink8 will use the hardware
> mac address in case of bogus nvs file?
>
With present implementation it will not. It will use the random one for both
wilink6/7 as well as wilink8.
I need to get a hold of a wilink6/7 module and see if reverting to an internal
mac address is working. Will try to look around as it has been a while since
I used one.
Best Regards,
Eyal
next prev parent reply other threads:[~2017-08-08 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1502090869-8833-1-git-send-email-eyalr@ti.com>
2017-08-07 7:31 ` [v5] wlcore: add missing nvs file name info for wilink8 Reizer, Eyal
2017-08-07 7:38 ` Tony Lindgren
2017-08-07 7:46 ` Reizer, Eyal
2017-08-08 4:20 ` Tony Lindgren
2017-08-08 8:03 ` Reizer, Eyal [this message]
2017-08-09 7:24 ` Reizer, Eyal
2017-08-09 16:59 ` Tony Lindgren
2017-08-07 12:38 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8665E2433BC68541A24DFFCA87B70F5B3641F73A@DFRE01.ent.ti.com \
--to=eyalr@ti.com \
--cc=julian.calaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).