From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF6E0CA9EA0 for ; Sun, 20 Oct 2019 09:35:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C228218BA for ; Sun, 20 Oct 2019 09:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571564100; bh=zUKzgKQQEtLwc+ZNQX3WQQkyBzsOn+E60JRR68wRRik=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=K5mh3Q3Macs+OQMIk5JPnUlUIJd1OMiyL2X88zVv1tvqotUS/SYi2gVfvzKlbGlv4 bBVsqkrJTbOriOT+BsOFf9LjbaEc9Lpi4gYZrVgRfI/01YlIqMZ0UohQyY/0pNfAID FlzoRlMt39rggtDDIv9mHHYemk+8Tg94iuwsGvw4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbfJTJe7 (ORCPT ); Sun, 20 Oct 2019 05:34:59 -0400 Received: from inca-roads.misterjones.org ([213.251.177.50]:33251 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725893AbfJTJe7 (ORCPT ); Sun, 20 Oct 2019 05:34:59 -0400 Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iM7by-0001qi-Bk; Sun, 20 Oct 2019 11:34:54 +0200 Date: Sun, 20 Oct 2019 10:34:52 +0100 Message-ID: <867e4zzrnn.wl-maz@kernel.org> From: Marc Zyngier To: Julia Lawall Cc: Markus Elfring , Himanshu Jha , kernel-janitors@vger.kernel.org, Coccinelle , Alexandre Belloni , linux-kernel@vger.kernel.org, Andy Shevchenko , Arnd Bergmann , Bartosz Golaszewski , Gilles Muller , Greg Kroah-Hartman , Linus Torvalds , Linus Walleij , Masahiro Yamada , Michal Marek , Nicolas Palix , Thomas Gleixner , YueHaibing Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script In-Reply-To: References: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> <868spgzcti.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: julia.lawall@lip6.fr, Markus.Elfring@web.de, himanshujha199640@gmail.com, kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bgolaszewski@baylibre.com, Gilles.Muller@lip6.fr, gregkh@linuxfoundation.org, torvalds@linuxfoundation.org, linus.walleij@linaro.org, yamada.masahiro@socionext.com, michal.lkml@markovi.net, nicolas.palix@imag.fr, tglx@linutronix.de, yuehaibing@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Oct 2019 06:38:30 +0100, Julia Lawall wrote: > > > If said script was providing a correct semantic patch instead of being > > an incentive for people to churn untested patches that span the whole > > tree, that'd be a different story. But that's not what this is about. > > What is the actual incorrectness with the script? The first thing is that it spits out a "WARNING", which is almost universally interpreted as something that needs addressing. In this case, it really doesn't. The suggested helper is only icing sugar, and the original code is perfectly fine. The second thing is that it results in people posting patches they don't even compile, let alone test. There would be a good chance for these patches to be correct if the script was directly generating them, but that's unfortunately not the case. > An option could be to adjust the rule such that it can be run with an > extra command line option, like -D developer but is not run by default by > make coccicheck. Maybe. I'm not sure this will deter people from running these scripts and sending broken patches anyway. No matter how many safeguards you put, people will still post broken patches just because they can. M. -- Jazz is not dead, it just smells funny.