From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Jeremy Fitzhardinge" <jeremy@goop.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
"Xen Devel" <xen-devel@lists.xensource.com>,
"Andi Kleen" <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Xen-devel] [PATCH 7 of 7] x86: always explicitly map acpi memory
Date: Sun, 7 Sep 2008 16:35:25 -0700 [thread overview]
Message-ID: <86802c440809071635l1457659bufeefa6e65cc34bdf@mail.gmail.com> (raw)
In-Reply-To: <6f23bad119ae2ed00f1c.1220826079@localhost>
On Sun, Sep 7, 2008 at 3:21 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Always map acpi tables, rather than assuming we can use the normal
> linear mapping to access the acpi tables. This is necessary in a
> virtual environment where the linear mappings are to pseudo-physical
> memory, but the acpi tables exist at a real physical address. It
> doesn't hurt to map in the normal non-virtual case, so just do it
> unconditionally.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> arch/x86/kernel/acpi/boot.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -126,9 +126,6 @@
>
> if (!phys || !size)
> return NULL;
> -
> - if (phys+size <= (max_low_pfn_mapped << PAGE_SHIFT))
> - return __va(phys);
>
> if (prev_map)
> early_iounmap(prev_map, prev_size);
>
actually,
case 1: acpi tables near mmio, range, we don't map them from
2.6.27-rc1, and it is bigger than max_low_mapped...
case 2: some strange system put acpi in the middle of RAM... like when
8G ram installed, but MMIO is 3.5G, BIOS put acpi tables around 2G..
YH
next prev parent reply other threads:[~2008-09-07 23:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 22:21 [PATCH 0 of 7] x86: lay groundwork for Xen domain 0 support Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 1 of 7] x86: add _PAGE_IOMAP pte flag for IO mappings Jeremy Fitzhardinge
2008-09-09 13:32 ` Avi Kivity
2008-09-09 14:47 ` Jeremy Fitzhardinge
2008-09-09 14:56 ` Avi Kivity
2008-09-09 15:29 ` [Xen-devel] " Keir Fraser
2008-09-09 15:48 ` Jeremy Fitzhardinge
2008-09-09 16:05 ` Keir Fraser
2008-09-10 9:55 ` Avi Kivity
2008-09-10 16:38 ` Jeremy Fitzhardinge
2008-09-10 16:55 ` Nick Piggin
2008-09-10 17:27 ` Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 2 of 7] x86: remove duplicate early_ioremap declarations Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 3 of 7] x86: add early_memremap() Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 4 of 7] x86: use early_memremap() in setup.c Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 5 of 7] x86-64: don't check for map replacement Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table Jeremy Fitzhardinge
2008-09-07 23:44 ` Andi Kleen
2008-09-08 0:03 ` Jeremy Fitzhardinge
2008-09-08 14:26 ` Ingo Molnar
2008-09-08 16:29 ` Jeremy Fitzhardinge
2008-09-08 19:41 ` Jeremy Fitzhardinge
2008-09-10 11:55 ` Ingo Molnar
2008-09-10 16:49 ` Jeremy Fitzhardinge
2008-09-11 7:33 ` Ingo Molnar
2008-09-11 18:36 ` Jeremy Fitzhardinge
2008-09-11 18:56 ` Ingo Molnar
2008-09-11 20:34 ` Yinghai Lu
2008-09-11 21:07 ` Jeremy Fitzhardinge
2008-09-12 9:49 ` Ingo Molnar
2008-09-12 17:31 ` Yinghai Lu
[not found] ` <20080911125748.GA14698@elte.hu>
2008-09-11 21:33 ` [PATCH] acpi: remove final __acpi_map_table mapping before setting acpi_gbl_permanent_mmap Jeremy Fitzhardinge
2008-09-07 22:21 ` [PATCH 7 of 7] x86: always explicitly map acpi memory Jeremy Fitzhardinge
2008-09-07 23:35 ` Yinghai Lu [this message]
2008-09-08 0:02 ` [Xen-devel] " Jeremy Fitzhardinge
2008-09-08 0:14 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440809071635l1457659bufeefa6e65cc34bdf@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).