From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E32C433FE for ; Tue, 4 Oct 2022 19:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiJDTof (ORCPT ); Tue, 4 Oct 2022 15:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiJDToc (ORCPT ); Tue, 4 Oct 2022 15:44:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4716A497 for ; Tue, 4 Oct 2022 12:44:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6ABE26150B for ; Tue, 4 Oct 2022 19:44:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C419EC433C1; Tue, 4 Oct 2022 19:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664912670; bh=JpbmUn4J/dmt8TLzLbsAjvW/Udpj2QY6i9oZphMlx4o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=km/a78RD/YFHONVthOydOcVRKrF4m+xlJg61NrG3sj5gf4jedLHQzN6XSEZ/7Xfw9 Ks1rwW5itsf1G8m/f1zMvsO2bgpm+F0bjSML3Awva2Y4Jxb5V/ieGRrvrvbFGrwkGq 3H5z88zoHRlGlXbAhSJ8FCr6dsHqUYzNVRExIVj2izWHLAlUdfFBadEFDm5nAAhDLU Ppxi5tTFweX7YvIB2MwNIti1hnBcu4JyGBW/pL+p00yF1Lj4GwWuEiTuQ/lEyxm7Kb oa082F7+++qFNdwyrD8YfUFKFeqy1/xsjg2n9Sqg87k7XxXTZamY+iYT+JHqBgZAAL RlsP+ntUrE4+g== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ofnq8-00Eatf-8J; Tue, 04 Oct 2022 20:44:28 +0100 Date: Tue, 04 Oct 2022 20:44:27 +0100 Message-ID: <868rlv8jc4.wl-maz@kernel.org> From: Marc Zyngier To: "Colin King (gmail)" , Frank Li Cc: Thomas Gleixner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "linux-kernel@vger.kernel.org" Subject: Re: irqchip: Add IMX MU MSI controller driver In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: colin.i.king@gmail.com, Frank.Li@nxp.com, tglx@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Oct 2022 20:37:46 +0100, "Colin King (gmail)" wrote: > > Hi, > > Static analysis with clang scan-build detected an issue with the > following commit in linux-next: > > commit 70afdab904d2d1e68bffe75fe08e7e48e0b0ff8e > Author: Frank Li > Date: Thu Sep 22 11:12:43 2022 -0500 > > irqchip: Add IMX MU MSI controller driver > > The issue is as follows in source drivers/irqchip/irq-imx-mu-msi.c : > > > static const struct imx_mu_dcfg imx_mu_cfg_imx8ulp = { > .type = IMX_MU_V2, > .xTR = 0x200, > .xRR = 0x280, > .xSR = { > [IMX_MU_SR] = 0xC, > [IMX_MU_GSR] = 0x118, > [IMX_MU_GSR] = 0x124, /* <--- issue here */ > [IMX_MU_RSR] = 0x12C, > }, > .xCR = { > [IMX_MU_GIER] = 0x110, > [IMX_MU_GCR] = 0x114, > [IMX_MU_TCR] = 0x120, > [IMX_MU_RCR] = 0x128 > }, > }; > > The .xSR object with index IMX_MU_GSR is being set twice, once with > 0x118 and again with 0x128. I believe the first one should be > IMX_MU_TSR but w/o the datasheet I don't want to make any assumptions. Huh, nice catch. Frank, can you please provide a fix for this ASAP? Thanks, M. -- Without deviation from the norm, progress is not possible.