From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C51FACA9EAB for ; Sat, 19 Oct 2019 20:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9746821D7C for ; Sat, 19 Oct 2019 20:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571517792; bh=zxx50TMzRXAth8huou+7P34K60EubXkjXgzDpMEqllk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=hpuBp5Eb9eEjqeL63SQZ7w1Rz0cnliQz2SAzLwTonbyLmnCmyfwMhtsNWv1mLsYvF jmsLk8FAk2UsfYImXvgU4VuWXDrQNSb12Kkde//7j9cLPq0b1mxrROjlVOIR8HZ3I+ UOZI86Az1viT9KvN3v4h3uPugFIwN8XquC9fR8ok= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbfJSUnL (ORCPT ); Sat, 19 Oct 2019 16:43:11 -0400 Received: from inca-roads.misterjones.org ([213.251.177.50]:40930 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbfJSUnL (ORCPT ); Sat, 19 Oct 2019 16:43:11 -0400 Received: from [185.104.136.17] (helo=big-swifty.misterjones.org) by cheepnis.misterjones.org with esmtpsa (TLSv1.2:AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1iLvZ4-0003m8-1D; Sat, 19 Oct 2019 22:43:06 +0200 Date: Sat, 19 Oct 2019 21:43:05 +0100 Message-ID: <868spgzcti.wl-maz@kernel.org> From: Marc Zyngier To: Markus Elfring Cc: Himanshu Jha , Julia Lawall , kernel-janitors@vger.kernel.org, Coccinelle , Alexandre Belloni , linux-kernel@vger.kernel.org, Andy Shevchenko , Arnd Bergmann , Bartosz Golaszewski , Gilles Muller , Greg Kroah-Hartman , Linus Torvalds , Linus Walleij , Masahiro Yamada , Michal Marek , Nicolas Palix , Thomas Gleixner , YueHaibing Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script In-Reply-To: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> References: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.17 X-SA-Exim-Rcpt-To: Markus.Elfring@web.de, himanshujha199640@gmail.com, julia.lawall@lip6.fr, kernel-janitors@vger.kernel.org, cocci@systeme.lip6.fr, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, arnd@arndb.de, bgolaszewski@baylibre.com, Gilles.Muller@lip6.fr, gregkh@linuxfoundation.org, torvalds@linuxfoundation.org, linus.walleij@linaro.org, yamada.masahiro@socionext.com, michal.lkml@markovi.net, nicolas.palix@imag.fr, tglx@linutronix.de, yuehaibing@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Oct 2019 12:35:49 +0100, Markus Elfring wrote: > > > I think part of the issue is that the script reports a WARNING > > How much does this information influence really the stress tolerance > and change resistance (or acceptance) for the presented collateral evolution? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/scripts/coccinelle/api/devm_platform_ioremap_resource.cocci -ENOPARSE. > > for something that is definitely correct code, > > Can related software improvement possibilities be taken into account > again under other circumstances? These patches provide no improvement whatsoever. As pointed out, they mostly introduce bugs. > > and could instead be simply toned down. > > Does this view mean that the mentioned script for the semantic patch language > should get another chance for integration? Providing Coccinelle scripts that scream about perfectly valid code is pointless, and the result is actively harmful. If said script was providing a correct semantic patch instead of being an incentive for people to churn untested patches that span the whole tree, that'd be a different story. But that's not what this is about. > > Anyway, FWIW: > > > > Acked-by: Marc Zyngier > > Would you like to share any more constructive feedback? No. > Will similar source file mass updates be better picked up > by other well-known Linux developers? Certainly not for the subsystems I maintain. M. -- Jazz is not dead, it just smells funny.