* [PATCH net-next] net: ethernet: mediatek: fix typo in offload code
@ 2021-04-15 9:40 DENG Qingfang
2021-04-15 10:05 ` Frank Wunderlich
0 siblings, 1 reply; 2+ messages in thread
From: DENG Qingfang @ 2021-04-15 9:40 UTC (permalink / raw)
To: Felix Fietkau, John Crispin, Sean Wang, Mark Lee,
David S. Miller, Jakub Kicinski, Matthias Brugger,
Pablo Neira Ayuso, netdev, linux-arm-kernel, linux-mediatek,
linux-kernel
Cc: Frank Wunderlich, Alex Ryabchenko
.key_offset was assigned to .head_offset instead. Fix the typo.
Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
index 4975106fbc42..f47f319f3ae0 100644
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
@@ -43,7 +43,7 @@ struct mtk_flow_entry {
static const struct rhashtable_params mtk_flow_ht_params = {
.head_offset = offsetof(struct mtk_flow_entry, node),
- .head_offset = offsetof(struct mtk_flow_entry, cookie),
+ .key_offset = offsetof(struct mtk_flow_entry, cookie),
.key_len = sizeof(unsigned long),
.automatic_shrinking = true,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: ethernet: mediatek: fix typo in offload code
2021-04-15 9:40 [PATCH net-next] net: ethernet: mediatek: fix typo in offload code DENG Qingfang
@ 2021-04-15 10:05 ` Frank Wunderlich
0 siblings, 0 replies; 2+ messages in thread
From: Frank Wunderlich @ 2021-04-15 10:05 UTC (permalink / raw)
To: linux-mediatek, DENG Qingfang, Felix Fietkau, John Crispin,
Sean Wang, Mark Lee, David S. Miller, Jakub Kicinski,
Matthias Brugger, Pablo Neira Ayuso, netdev, linux-arm-kernel,
linux-kernel
Cc: Alex Ryabchenko
Am 15. April 2021 11:40:05 MESZ schrieb DENG Qingfang <dqfext@gmail.com>:
>.key_offset was assigned to .head_offset instead. Fix the typo.
>
>Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading
>support")
>Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Thanks for posting the fix,but imho commit-message is not good.
Issue were traffic problems after a while with increased ping times if flow offload is active.
It turns out that key_offset with cookie is needed in rhashtable_params and head_offset was defined twice.
regards Frank
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-15 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 9:40 [PATCH net-next] net: ethernet: mediatek: fix typo in offload code DENG Qingfang
2021-04-15 10:05 ` Frank Wunderlich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).