From: Icenowy Zheng <icenowy@aosc.io>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi
Date: Wed, 25 Nov 2020 07:30:50 +0800 [thread overview]
Message-ID: <86cfbd41fe80b4936f20925aed0c9010806a0316.camel@aosc.io> (raw)
In-Reply-To: <20201124225940.3750388-1-icenowy@aosc.io>
在 2020-11-25星期三的 06:59 +0800,Icenowy Zheng写道:
> The PineCube board has a RTL8189ES Wi-Fi module on board, and the
> module
> doesn't have any MAC address programmed in.
Sorry, but now I'm unsure about this.
The module seems to have MAC address programmed.
>
> Add a ethernet alias in the DT, thus the bootloader will then be able
> to
> generate a MAC address into the device tree node of Wi-Fi.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> arch/arm/boot/dts/sun8i-s3-pinecube.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> index 4aa0ee897a0a..5086f713467a 100644
> --- a/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> +++ b/arch/arm/boot/dts/sun8i-s3-pinecube.dts
> @@ -13,6 +13,7 @@ / {
> compatible = "pine64,pinecube", "sochip,s3", "allwinner,sun8i-
> v3";
>
> aliases {
> + ethernet0 = &rtl8189es;
> serial0 = &uart2;
> };
>
> @@ -156,6 +157,10 @@ &mmc1 {
> bus-width = <4>;
> non-removable;
> status = "okay";
> +
> + rtl8189es: wifi@1 {
> + reg = <1>;
> + };
> };
>
> &pio {
prev parent reply other threads:[~2020-11-24 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 22:59 [PATCH] ARM: dts: sun8i: s3: pinecube: add ethernet alias for Wi-Fi Icenowy Zheng
2020-11-24 23:30 ` Icenowy Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cfbd41fe80b4936f20925aed0c9010806a0316.camel@aosc.io \
--to=icenowy@aosc.io \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).