From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbdK3Jof (ORCPT ); Thu, 30 Nov 2017 04:44:35 -0500 Received: from foss.arm.com ([217.140.101.70]:49874 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdK3Jod (ORCPT ); Thu, 30 Nov 2017 04:44:33 -0500 From: Marc Zyngier To: "dbasehore ." Cc: linux-kernel , Thomas Gleixner , sudeep.holla@arm.com, Linux-pm mailing list Subject: Re: Save and Restore Generic Interrupt Controller for System Sleep on ARM In-Reply-To: (dbasehore .'s message of "Wed, 29 Nov 2017 14:49:18 -0800") Organization: ARM Ltd References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Thu, 30 Nov 2017 09:44:26 +0000 Message-ID: <86d140xfr9.fsf@unassigned-hostname.unassigned-domain> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29 2017 at 2:49:18 pm GMT, "dbasehore ." wrote: > There was some work in ARM Trusted Firmware to support saving and > restoring the Generic Interrupt Controller (GICv3) before and after > sleep, but it seems that the plan is to have this all in the kernel > now. The point of doing this is to save power during sleep. On an > RK3399 system, we save about 15mW by disabling the power rail that the > GIC is on. > > I was looking for whether anyone had anything in progress already or > for preferences on how to do this. Marc suggested using a device tree > entry to indicate the need to save and restore the GIC. There is > another requirement to resend MAPC commands on certain implementations > of the GICv3 which could be indicated by another device tree entry. Let's be precise: This is a GIC-500 requirement, and not something that the GICv3 architecture defines (PM is *not* part of the GICv3 architecture). > If someone does have patches, I'll be able to test and verify them on > my system since we've gotten things working with the ARM Trusted > Firmware patches. I'm not aware of any such patch that has been posted for mainline, so just post whatever you have and we'll take it from there. IT is hard to comment further on what you're trying to do without seeing the code and a description of the new API between ATF and the kernel. Thanks, M. -- Jazz is not dead, it just smell funny.