From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751880AbcEUC7U (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 May 2016 22:59:20 -0400
Received: from mail-wm0-f53.google.com ([74.125.82.53]:37982 "EHLO
	mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751582AbcEUC7S (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 May 2016 22:59:18 -0400
From: Gabriel C <nix.or.die@gmail.com>
Subject: Re: Builtin microcode does nothing..
To: Borislav Petkov <bp@suse.de>
References: <CAEJqkghOm3RMetBSxC-suZN7cqnWT0Lsn0nsOZ2-Mzp6i5cGDQ@mail.gmail.com>
 <323291d3-64ae-4648-a731-e695dab2df04@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Message-ID: <86dacf1e-83ca-8dd9-c9b4-513c1e40dd2a@gmail.com>
Date: Sat, 21 May 2016 04:59:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <323291d3-64ae-4648-a731-e695dab2df04@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21.05.2016 02:20, Gabriel C wrote:

> On 20.05.2016 12:08, Gabriel C wrote:
>
>>> Does it work when you disable CONFIG_BLK_DEV_INITRD in there?
>> I can test this when I'm home since I need to change the config a bit.
>
> I got to test an kernel without CONFIG_BLK_DEV_INITRD and this way 
> does work.
>

While that worked I read the code not sure I get this right but:

scan_microcode() has :

...
       if (!size) {
         if (!load_builtin_intel_microcode(&cd))
             return UCODE_ERROR;
     } else {
         cd = find_cpio_data(p, (void *)start, size, &offset);
         if (!cd.data)
             return UCODE_ERROR;
     }

...

So when I get this correctly load_builtin_intel_microcode() only works 
on !initrd ?

Should this check not be the other way around ?

something like :

       cd = find_cpio_data(p, (void *)start, size, &offset);
       if (!cd.data) {
            if (!load_builtin_intel_microcode(&cd))
                  return UCODE_ERROR;
       }


Regards,

Gabriel C