From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932201AbdJYHvc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 25 Oct 2017 03:51:32 -0400
Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34236 "EHLO
        foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932109AbdJYHva (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 25 Oct 2017 03:51:30 -0400
From: Marc Zyngier <marc.zyngier@arm.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: <tglx@linutronix.de>, <jason@lakedaemon.net>,
        <gregory.clement@free-electrons.com>, <andrew@lunn.ch>,
        <sebastian.hesselbarth@gmail.com>,
        <thomas.petazzoni@free-electrons.com>,
        <miquel.raynal@free-electrons.com>, <nadavh@marvell.com>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init
In-Reply-To: <20171025072326.21030-1-antoine.tenart@free-electrons.com>
        (Antoine Tenart's message of "Wed, 25 Oct 2017 09:23:26 +0200")
Organization: ARM Ltd
References: <20171025072326.21030-1-antoine.tenart@free-electrons.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)
Date: Wed, 25 Oct 2017 08:51:24 +0100
Message-ID: <86efprfywz.fsf@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 25 2017 at  9:23:26 am BST, Antoine Tenart <antoine.tenart@free-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  drivers/irqchip/irq-mvebu-gicp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	gicp->dev = &pdev->dev;
> +	spin_lock_init(&gicp->spi_lock);
>  
>  	gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!gicp->res)

Cc: stable@vger.kernel.org
Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Thomas, can you please queue this ASAP?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.