From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AA4C4360F for ; Thu, 14 Feb 2019 10:46:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 314EB222B6 for ; Thu, 14 Feb 2019 10:46:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405427AbfBNKqc (ORCPT ); Thu, 14 Feb 2019 05:46:32 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:41126 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394267AbfBNKqa (ORCPT ); Thu, 14 Feb 2019 05:46:30 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E9E9EBD; Thu, 14 Feb 2019 02:46:30 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 980863F575; Thu, 14 Feb 2019 02:46:28 -0800 (PST) Date: Thu, 14 Feb 2019 10:46:25 +0000 Message-ID: <86pnrusl4u.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Zenghui Yu Cc: , , , , , Subject: Re: [PATCH] irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table In-Reply-To: <1549776250-4464-1-git-send-email-yuzenghui@huawei.com> References: <1549776250-4464-1-git-send-email-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Feb 2019 05:24:10 +0000, Zenghui Yu wrote: > > In current logic, its_parse_indirect_baser() will be invoked twice > when allocating Device tables. Add a *break* to omit the unnecessary > and annoying (might be ...) invoking. > > Signed-off-by: Zenghui Yu > --- > drivers/irqchip/irq-gic-v3-its.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index db20e99..9f529a6 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -1946,6 +1946,8 @@ static int its_alloc_tables(struct its_node *its) > indirect = its_parse_indirect_baser(its, baser, > psz, &order, > its->device_ids); > + break; > + > case GITS_BASER_TYPE_VCPU: > indirect = its_parse_indirect_baser(its, baser, > psz, &order, Nice catch. I've applied this to irqchip-next with the Fixes tag and a Cc stable. Thanks, M. -- Jazz is not dead, it just smell funny.