From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9634CC282C0 for ; Sun, 27 Jan 2019 10:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 681982146E for ; Sun, 27 Jan 2019 10:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbfA0KPI (ORCPT ); Sun, 27 Jan 2019 05:15:08 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:34682 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726453AbfA0KPI (ORCPT ); Sun, 27 Jan 2019 05:15:08 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 573A9A78; Sun, 27 Jan 2019 02:15:07 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 698A53F237; Sun, 27 Jan 2019 02:15:04 -0800 (PST) Date: Sun, 27 Jan 2019 10:14:58 +0000 Message-ID: <86pnsiwgnx.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Zhou Yanjie Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, paul.burton@mips.com, mark.rutland@arm.com, jason@lakedaemon.net, tglx@linutronix.de, syq@debian.org, jiaxun.yang@flygoat.com, 772753199@qq.com Subject: Re: [PATCH 3/4] Irqchip: Ingenic: Add support for the X1000. In-Reply-To: <1548517123-60058-4-git-send-email-zhouyanjie@zoho.com> References: <1548517123-60058-1-git-send-email-zhouyanjie@zoho.com> <1548517123-60058-4-git-send-email-zhouyanjie@zoho.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Jan 2019 15:38:42 +0000, Zhou Yanjie wrote: > > Add support for probing the irq-ingenic driver on the X1000 Soc. > X1000 is a 1.0GHz processor for IoT. It has MIPS32 XBurst RISC core > with double precision hardware float point unit. I don't think we need the marketing spiel, as none of the advertised target market, ISA or feature set of this SoC is relevant for this patch. Put it in the cover letter if you must. Instead, explaining that it behaves just like any of the other "2chip" Ingenic SoCs makes is much more relevant. > > Signed-off-by: Zhou Yanjie > --- > drivers/irqchip/irq-ingenic.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/irq-ingenic.c b/drivers/irqchip/irq-ingenic.c > index 69be219..0b643c7 100644 > --- a/drivers/irqchip/irq-ingenic.c > +++ b/drivers/irqchip/irq-ingenic.c > @@ -177,3 +177,4 @@ static int __init intc_2chip_of_init(struct device_node *node, > IRQCHIP_DECLARE(jz4770_intc, "ingenic,jz4770-intc", intc_2chip_of_init); > IRQCHIP_DECLARE(jz4775_intc, "ingenic,jz4775-intc", intc_2chip_of_init); > IRQCHIP_DECLARE(jz4780_intc, "ingenic,jz4780-intc", intc_2chip_of_init); > +IRQCHIP_DECLARE(x1000_intc, "ingenic,x1000-intc", intc_2chip_of_init); > -- > 2.7.4 > > Thanks, M. -- Jazz is not dead, it just smell funny.