From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF1E3C43387 for ; Sat, 15 Dec 2018 09:16:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD5B721726 for ; Sat, 15 Dec 2018 09:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729995AbeLOJQ2 (ORCPT ); Sat, 15 Dec 2018 04:16:28 -0500 Received: from foss.arm.com ([217.140.101.70]:33800 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728731AbeLOJQ1 (ORCPT ); Sat, 15 Dec 2018 04:16:27 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ABEAFEBD; Sat, 15 Dec 2018 01:16:26 -0800 (PST) Received: from big-swifty.misterjones.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CCA6E3F575; Sat, 15 Dec 2018 01:16:21 -0800 (PST) Date: Sat, 15 Dec 2018 09:16:14 +0000 Message-ID: <86sgyzb15t.wl-marc.zyngier@arm.com> From: Marc Zyngier To: Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , Kees Cook , "Gustavo A. R. Silva" , Andrey Smirnov Subject: Re: linux-next: build warning after merge of the irqchip tree In-Reply-To: <20181214144406.0dbffbc8@canb.auug.org.au> References: <20181214144406.0dbffbc8@canb.auug.org.au> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: ARM Ltd MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Dec 2018 03:44:06 +0000, Stephen Rothwell wrote: > > [1 ] > Hi all, > > After merging the irqchip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > In file included from include/linux/io.h:25, > from include/linux/of_address.h:7, > from drivers/irqchip/irq-imx-gpcv2.c:9: > drivers/irqchip/irq-imx-gpcv2.c: In function 'imx_gpcv2_irqchip_init': > arch/arm/include/asm/io.h:96:22: warning: this statement may fall through [-Wimplicit-fallthrough=] > #define __raw_writel __raw_writel > ^ > arch/arm/include/asm/io.h:305:29: note: in expansion of macro '__raw_writel' > #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c) > ^~~~~~~~~~~~ > drivers/irqchip/irq-imx-gpcv2.c:263:4: note: in expansion of macro 'writel_relaxed' > writel_relaxed(~0, reg + GPC_IMR1_CORE3); > ^~~~~~~~~~~~~~ > drivers/irqchip/irq-imx-gpcv2.c:264:3: note: here > case 2: /* FALLTHROUGH */ > ^~~~ > > Introduced by commit > > ed01edc0ab6f ("irqchip/irq-imx-gpcv2: Add support for i.MX8MQ") > > This is caused by my use of -Wimplicit-fallthrough for Kees Cook. > > Replacing the "/* FALLTHROUGH */" with "/* fall through */" but on the > line above will suppress the warning. I've now pushed out a patch that does exactly that. Thanks for spotting this. M. -- Jazz is not dead, it just smell funny.