From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbaD1Wdw (ORCPT ); Mon, 28 Apr 2014 18:33:52 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:59685 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751553AbaD1Wdu (ORCPT ); Mon, 28 Apr 2014 18:33:50 -0400 From: "Rafael J. Wysocki" To: Adam Williamson Cc: Lan Tianyu , wsa@the-dreams.de, mika.westerberg@linux.intel.com, lenb@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Lv Zheng Subject: Re: [Patch V2 1/9] ACPICA: Executer: Fix buffer allocation issue for generic_serial_bus region field accesses. Date: Tue, 29 Apr 2014 00:50:18 +0200 Message-ID: <8704550.LJW911OU1k@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.14.0-rc7+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1398708505.2843.17.camel@adam.happyassassin.net> References: <1398147855-9868-1-git-send-email-tianyu.lan@intel.com> <1398707520.2843.16.camel@adam.happyassassin.net> <1398708505.2843.17.camel@adam.happyassassin.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, April 28, 2014 11:08:25 AM Adam Williamson wrote: > On Mon, 2014-04-28 at 10:52 -0700, Adam Williamson wrote: > > On Mon, 2014-04-28 at 22:27 +0800, Lan Tianyu wrote: > > > From: Lv Zheng > > > > > > The size of the buffer allocated for generic_serial_bus region access > > > is not correct. This patch introduces acpi_ex_get_serial_access_length() > > > to be invoked to obtain correct data buffer length. Reported by > > > Lan Tianyu, Fixed by Lv Zheng. > > > > > > Reviewed-by: Mika Westerberg > > > Signed-off-by: Lv Zheng > > > Signed-off-by: Lan Tianyu > > > > Very superficial issue, and sorry I forgot to mention it for v1, but the > > summary line for this patch (1/9) ends with a period - "...region field > > accesses." - which I think is not the correct style? Well, some people do that, but is it really a problem? > In fact, it seems this patch already got merged into Linus' tree > somehow: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/acpi/acpica/exfield.c?id=6273f00e6ecbd60494a979033b7e5271a29a0436 Yes, I wanted to have it in there now. > the others do not seem to have been merged yet. The rest has been queued up for 3.16. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.